Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Go-Ethereum release v1.9.8 #1112

Merged
merged 1,153 commits into from
Feb 2, 2021

Conversation

ricardolyn
Copy link
Contributor

@ricardolyn ricardolyn commented Jan 14, 2021

TODO

Plan & Analyse

  • Review the Release Notes
  • Review PRs in the section below

As you review, list extra changes and/or tests to be implemented to ensure compatibility with GoQuorum specific features.

Build & Test

  • Pull and checkout PR branch locally, then merge GoQuorum master into this branch
  • Resolve conflicts, taking into account the prior analysis
  • Implement required changes until all unit tests pass
  • Implement required changes until acceptance tests pass
  • Implement extra changes and/or tests

Extra Changes & Tests

  • Unit test: Add unit test to verify that ID is actually parsed from the RPC request into the context
  • Go Modules: Updated go version in go.mod to 1.15

Go-Ethereum Release: Thessian Temple (v1.9.8)

  • Version: v1.9.8
  • Published: 2019-11-26T10:26:50Z

Release notes

Geth v1.9.8 is yet another biweekly maintenance release, but that does mean it only contains fixes! Two highlights of the release are switching the entire code base over to Go modules (#20311); and replacing the trie cacher, slashing memory consumption on mainnet - using default configs - by 1GB (#19971).

Note: Go modules were introduced in Go 1.11 and greatly polished throughout Go 1.13. Although Geth builds fine with Go 1.11 and Go 1.12 too, we recommend running at least Go 1.13 as it is more flexible in handling various circumstances. If you are using go-ethereum as a library, converting your project to Go modules via go mod init will make dependency management a lot less of a hassle than the vendor approach. Be aware, however, that Go modules require network access if the dependencies aren't yet cached locally.

Other notable changes:

  • Switch the deprecated web socket library to github.com/gorilla/websocket (#20283, #20289).
  • Deprecate the gometalinter in favor of golangci-lint (#20295 + dozens of linter fixes).
  • Support aliases to manually resolve name clashes in abigen generated code (#20244).
  • Add clique_status API to quickly glance the health of Clique networks (#20103).
  • Initial version of a light server priority API to allow incentivized services (#20070).
  • Make puppeth SSH key confirmation friendlier with bad user input (#20350).
  • Support loading transaction input from files in the evm utility (#20273).
  • Allow digits inside of labels for the internal assembler (#20362).

For a full rundown of the changes please consult the Geth 1.9.8 release milestone.


As with all our previous releases, you can find the:

Codebase changes assesment

Legend

File Stats: (A) Added, (M) Modified and (R) Removed

Line Stats: (A) Added and (R) Removed

Assessment:

  • ✅ No conflict expected
  • ⚠ Review required to assess changes
  • ‼️ Conflicts expected and review required

69 Pull Requests

🔍 Link Title File Stats
M/A/R
Packages changed
(files changed)
Line Stats
A/R
Top 5 Changed Files
(lines changed)
‼️ #20252 p2p/enode: mock DNS resolver in URL parsing test 2/0/0
p2p/enode (2)
21/6
p2p/enode/urlv4.go (34)
p2p/enode/urlv4_test.go (20)
‼️ #20219 travis: Enable ARM support in travis 6/1/0
metrics (3)
.travis.yml (1)
consensus/ethash (1)
eth (1)
miner (1)
74/54
metrics/ewma_test.go (202)
.travis.yml (20)
miner/worker_test.go (12)
metrics/doc.go (8)
metrics/sample_test.go (6)
#20277 p2p: fix bug in TestPeerDisconnect 1/0/0
p2p (1)
1/1
p2p/peer_test.go (4)
‼️ #19762 dashboard: send current block to the dashboard client 18/2/0
dashboard/assets/components (7)
dashboard (5)
p2p (3)
dashboard/assets (2)
cmd/geth (1)
cmd/utils (1)
dashboard/assets/types (1)
15775/14732
dashboard/assets.go (55152)
dashboard/assets/yarn.lock (2798)
dashboard/assets/components/Network.jsx (1406)
dashboard/peers.go (560)
dashboard/dashboard.go (168)
‼️ #20268 miner: increase worker test timeout 1/0/0
miner (1)
1/1
miner/worker_test.go (4)
‼️ #20070 les: implement server priority API 6/0/0
les (5)
internal/web3ext (1)
597/107
les/clientpool.go (592)
les/api.go (562)
les/clientpool_test.go (108)
internal/web3ext/web3ext.go (68)
les/server.go (62)
‼️ #20244 accounts/abi/bind, cmd/abigen: implement alias for abigen 3/0/0
accounts/abi/bind (2)
cmd/abigen (1)
130/12
accounts/abi/bind/bind_test.go (140)
accounts/abi/bind/bind.go (82)
cmd/abigen/main.go (62)
‼️ #20284 Fix typo in rpc/doc.go 1/0/0
rpc (1)
1/1
rpc/doc.go (4)
⚠️ #20283 cmd/faucet: use github.com/gorilla/websocket 1/0/0
cmd/faucet (1)
11/7
cmd/faucet/faucet.go (36)
‼️ #20279 dashboard: remove the dashboard 4/0/26
dashboard/assets (12)
dashboard/assets/components (11)
cmd/geth (3)
dashboard (2)
dashboard/assets/types (1)
cmd/utils (1)
8/49683
dashboard/assets.go (78102)
dashboard/assets/yarn.lock (14966)
dashboard/assets/components/Network.jsx (1716)
dashboard/assets/components/Logs.jsx (654)
dashboard/assets/components/Dashboard.jsx (536)
#20288 whisper/whisperv6: Fix issues reported by staticcheck 2/0/0
whisper/whisperv6 (2)
2/3
whisper/whisperv6/topic.go (6)
whisper/whisperv6/whisper.go (4)
‼️ #20281 build: gather info to investigate why builds fail on ARM 2/0/0
.travis.yml (1)
build (1)
6/0
build/ci.go (8)
.travis.yml (4)
‼️ #20291 params: finish sentence in comment 1/0/0
params (1)
1/1
params/config.go (4)
#20294 tracer: fix interface parameter. 1/0/0
core/vm (1)
1/1
core/vm/logger.go (4)
#20273 cmd/evm: Allow loading input from file 2/0/0
cmd/evm (2)
17/2
cmd/evm/runner.go (28)
cmd/evm/main.go (10)
‼️ #20289 p2p/simulations: use github.com/gorilla/websocket 18/0/5
rpc (13)
vendor/golang.org/x/net/websocket (5)
p2p/simulations/adapters (3)
p2p/simulations (1)
vendor (1)
121/1391
vendor/golang.org/x/net/websocket/hybi.go (1166)
vendor/golang.org/x/net/websocket/websocket.go (902)
vendor/golang.org/x/net/websocket/server.go (226)
vendor/golang.org/x/net/websocket/client.go (212)
rpc/json.go (120)
#20295 build: use golangci-lint 25/3/1
p2p/simulations (4)
les (3)
internal/build (3)
build (2)
p2p/nat (2)
rlp (1)
signer/core (1)
.gitignore (1)
core (1)
crypto/bn256 (1)
core/state (1)
core/vm (1)
cmd/clef (1)
core/rawdb (1)
whisper/whisperv6 (1)
.travis.yml (1)
core/forkid (1)
crypto/ecies (1)
.golangci.yml (1)
cmd/utils (1)
354/316
internal/build/download.go (298)
build/ci.go (170)
internal/build/gosrc.go (162)
p2p/simulations/network_test.go (112)
cmd/clef/main.go (94)
‼️ #20296 travis: Remove traces and use travis_wait in ARM build 1/0/0
.travis.yml (1)
1/3
.travis.yml (8)
‼️ #20300 core: s/isEIP155/isEIP2/ (fix IntrinsicGas signature var name) 1/0/0
core (1)
2/2
core/state_transition.go (8)
‼️ #20304 les: rename UpdateBalance to AddBalance and simplify return format 5/0/0
les (4)
internal/web3ext (1)
28/31
les/balance.go (40)
les/clientpool_test.go (40)
les/api.go (22)
internal/web3ext/web3ext.go (8)
les/clientpool.go (8)
‼️ #20309 travis: Use travis_wait for both install and build 1/0/0
.travis.yml (1)
1/1
.travis.yml (4)
‼️ #20298 build: add test cmd flag -v for verbose logs 1/0/0
build (1)
4/0
build/ci.go (8)
‼️ #20314 cmd/clef: fix staticcheck warnings 1/0/0
cmd/clef (1)
3/3
cmd/clef/main.go (12)
‼️ #20103 consensus/clique: add clique_status API method 1/0/0
consensus/clique (1)
58/0
consensus/clique/api.go (116)
‼️ #20316 consensus/clique: fix struct tags for status API 1/0/0
consensus/clique (1)
4/4
consensus/clique/api.go (16)
#20313 cmd/ethkey: fix file permissions in changepassword command 1/0/0
cmd/ethkey (1)
1/1
cmd/ethkey/changepassword.go (4)
#20315 p2p/netutil: fix staticcheck warning 1/0/0
p2p/netutil (1)
1/1
p2p/netutil/net.go (4)
‼️ #20195 core/rawdb: check hash before return data from ancient db 2/0/0
core/rawdb (2)
158/37
core/rawdb/accessors_chain.go (258)
core/rawdb/accessors_chain_test.go (132)
‼️ #20321 travis: deactivate arm build during push 1/0/0
.travis.yml (1)
3/2
.travis.yml (10)
‼️ #20326 ethclient: remove use of common.ToHex 1/0/0
ethclient (1)
1/1
ethclient/ethclient.go (4)
#20327 cmd/wnode: remove uses of common.ToHex 1/0/0
cmd/wnode (1)
3/2
cmd/wnode/main.go (10)
#20324 event: remove unused field 'closed' 1/0/0
event (1)
3/4
event/feed.go (14)
‼️ #20329 .github: remove 'nonsense' from CODEOWNERS 1/0/0
.github (1)
3/3
.github/CODEOWNERS (12)
#20328 whisper/whisperv6: fix staticcheck warnings 2/0/0
whisper/whisperv6 (2)
3/29
whisper/whisperv6/peer_test.go (44)
whisper/whisperv6/filter_test.go (20)
‼️ #20325 p2p: remove unused code 3/0/0
p2p (3)
1/23
p2p/util.go (22)
p2p/rlpx.go (20)
p2p/server.go (6)
‼️ #20322 p2p/simulations: fix staticcheck warnings 5/0/0
p2p/simulations (3)
p2p/simulations/adapters (2)
122/184
p2p/simulations/adapters/inproc_test.go (538)
p2p/simulations/mocker_test.go (38)
p2p/simulations/http.go (18)
p2p/simulations/network_test.go (14)
p2p/simulations/adapters/exec.go (4)
‼️ #20318 internal/web3ext, les: update clique JS and make it work with the light client 3/0/0
internal/web3ext (1)
les (1)
light (1)
15/3
internal/web3ext/web3ext.go (18)
light/lightchain.go (10)
les/client.go (8)
‼️ #20332 rpc: remove 'exported or builtin' restriction for parameters 9/0/0
rpc (9)
36/76
rpc/client_test.go (64)
rpc/service.go (56)
rpc/testservice_test.go (30)
rpc/subscription.go (24)
rpc/doc.go (20)
‼️ #20323 core: fix staticcheck warnings 2/0/1
core (3)
7/99
core/helper_test.go (174)
core/blockchain_test.go (32)
core/chain_makers.go (6)
‼️ #20310 miner: fix data race in tests 3/0/0
miner (3)
28/104
miner/worker_test.go (246)
miner/worker.go (14)
miner/miner.go (4)
‼️ #20241 cmd/puppeth: update chain spec of parity 3/0/0
cmd/puppeth (2)
cmd/puppeth/testdata (1)
148/62
cmd/puppeth/genesis.go (244)
cmd/puppeth/testdata/stureby_parity.json (122)
cmd/puppeth/genesis_test.go (54)
‼️ #20261 internal/ethapi: don't query wallets at every execution of gas estimation 1/0/0
internal/ethapi (1)
12/0
internal/ethapi/api.go (24)
‼️ #20337 tests: enable TransactionTests Istanbul case 1/0/0
tests (1)
1/2
tests/transaction_test_util.go (6)
‼️ #20338 tests: refactor TestState to dedupe walk callback 1/0/0
tests (1)
17/25
tests/state_test.go (84)
‼️ #20339 cmd/puppeth: x-spec nonce data type, use types.BlockNonce 1/0/0
cmd/puppeth (1)
16/22
cmd/puppeth/genesis.go (76)
#20350 cmd/puppeth: make ssh prompt more user-friendly 1/0/0
cmd/puppeth (1)
14/9
cmd/puppeth/ssh.go (46)
‼️ #20353 common/hexutil: improve GraphQL error messages 1/0/0
common/hexutil (1)
3/3
common/hexutil/json.go (12)
‼️ #20311 go.mod: switch to Go modules 6/2/22
vendor/github.com/Azure/azure-pipeline-go/pipeline (10)
vendor/github.com/Azure/azure-sdk-for-go (5)
vendor/github.com/Azure/azure-storage-blob-go/azblob (5)
go.sum (1)
internal/build (1)
mobile (1)
vendor/github.com/Azure/azure-pipeline-go (1)
.travis.yml (1)
accounts/abi/bind (1)
build (1)
build/deb/ethereum (1)
go.mod (1)
vendor/github.com/Azure/azure-storage-blob-go (1)
333/10612
vendor/github.com/Azure/azure-storage-blob-go/azblob/blob.json (16018)
vendor/github.com/Azure/azure-storage-blob-go/azblob/highlevel.go (1076)
vendor/github.com/Azure/azure-pipeline-go/pipeline/core.go (568)
vendor/github.com/Azure/azure-sdk-for-go/CHANGELOG.md (560)
go.sum (428)
‼️ #20356 build: pull in ci.go dependencies for the PPA builder 1/0/0
build (1)
8/4
build/ci.go (24)
‼️ #20354 common: improve GraphQL error messages 2/0/1
common (3)
32/54
common/bytes_test.go (104)
common/main_test.go (50)
common/types.go (18)
‼️ #20355 core/types: remove BlockBy sorting code 2/0/0
core (1)
core/types (1)
4/26
core/types/block.go (48)
core/blockchain.go (12)
‼️ #20360 build: skip go clean on PPA, messes with the module trick 3/0/1
build (2)
Makefile (1)
build/deb/ethereum (1)
6/22
build/clean_go_build_cache.sh (38)
build/deb/ethereum/deb.rules (10)
Makefile (4)
build/ci.go (4)
‼️ #20359 accounts/abi/bind/backends: remove unused assignment 1/0/0
accounts/abi/bind/backends (1)
1/1
accounts/abi/bind/backends/simulated_test.go (4)
#20358 accounts/abi: fix staticcheck warnings 2/0/0
accounts/abi (2)
2/36
accounts/abi/event_test.go (72)
accounts/abi/abi_test.go (4)
#20357 core/state: fix staticcheck warnings 6/0/1
core/state (6)
go.mod (1)
211/228
core/state/statedb.go (600)
core/state/state_test.go (106)
core/state/dump.go (94)
core/state/main_test.go (50)
core/state/statedb_test.go (18)
#20365 metrics: fix issues reported by staticcheck 15/0/0
metrics (12)
metrics/librato (2)
metrics/influxdb (1)
109/105
metrics/sample_test.go (108)
metrics/histogram_test.go (68)
metrics/timer_test.go (64)
metrics/registry_test.go (44)
metrics/counter_test.go (32)
‼️ #20366 trie: remove unused code 2/0/0
trie (2)
7/63
trie/database.go (118)
trie/trie_test.go (22)
#20367 p2p/discv5: add deprecation warning and remove unused code 9/1/2
p2p/discv5 (12)
18/897
p2p/discv5/udp_test.go (900)
p2p/discv5/ntp.go (252)
p2p/discv5/table_test.go (198)
p2p/discv5/ticket.go (140)
p2p/discv5/net_test.go (88)
‼️ #20364 tests, signer: remove staticcheck warnings 12/0/0
signer/core (6)
tests (3)
signer/rules/deps (1)
signer/rules (1)
signer/storage (1)
60/68
tests/block_test_util.go (76)
signer/core/cliui.go (56)
signer/rules/deps/bindata.go (42)
tests/init_test.go (22)
tests/transaction_test_util.go (16)
#20362 core/asm: allow numbers in labels 2/0/0
core/asm (2)
9/1
core/asm/lex_test.go (16)
core/asm/lexer.go (4)
‼️ #20375 miner: fix staticcheck warnings 2/0/0
miner (2)
43/39
miner/miner.go (152)
miner/worker_test.go (12)
#20379 eth/tracers: fix staticcheck warnings 1/0/0
eth/tracers (1)
3/3
eth/tracers/tracer.go (12)
‼️ #19971 vendor, trie: replace bigCache with fastCache 3/0/0
go.mod (1)
go.sum (1)
trie (1)
20/17
trie/database.go (50)
go.sum (20)
go.mod (4)
‼️ #20385 cmd/geth: remove network id from version cmd 1/0/0
cmd/geth (1)
0/1
cmd/geth/misccmd.go (2)
‼️ #20368 rlp: fix staticcheck warnings 2/0/0
rlp (2)
10/10
rlp/decode.go (22)
rlp/decode_test.go (18)
‼️ #20381 accounts/abi/bind: avoid reclaring structs 3/0/0
accounts/abi/bind (3)
103/18
accounts/abi/bind/bind_test.go (164)
accounts/abi/bind/template.go (48)
accounts/abi/bind/bind.go (30)
#20373 accounts/keystore: fix staticcheck warnings 1/0/0
accounts/keystore (1)
5/4
accounts/keystore/passphrase.go (18)
‼️ #20389 p2p/discover: slow down lookups on empty table 1/0/0
p2p/discover (1)
16/0
p2p/discover/lookup.go (32)
‼️ #20395 les: fix clientInfo deadlock 1/0/0
les (1)
1/1
les/api.go (4)

313 Changed files

🔍 File Lines Changed Linked PR
‼️ dashboard/assets.go 77330 #19762
#20279
vendor/github.com/Azure/azure-storage-blob-go/azblob/blob.json 16018 #20311
‼️ dashboard/assets/yarn.lock 14816 #19762
#20279
dashboard/peers.go 1104 #19762
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/highlevel.go 1076 #20311
dashboard/assets/components/Network.jsx 1058 #19762
#20279
p2p/discv5/udp_test.go 900 #20367
‼️ dashboard/assets/components/Logs.jsx 654 #20279
‼️ core/state/statedb.go 600 #20357
‼️ les/clientpool.go 596 #20304
#20295
#20070
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/url_container.go 590
‼️ dashboard/log.go 576
‼️ vendor/github.com/Azure/azure-pipeline-go/pipeline/core.go 568 #20311
vendor/github.com/Azure/azure-sdk-for-go/CHANGELOG.md 560 #20311
‼️ dashboard/dashboard.go 560 #19762
‼️ les/api.go 556 #20304
#20070
#20395
p2p/simulations/adapters/inproc_test.go 538 #20322
‼️ dashboard/assets/components/Dashboard.jsx 516 #19762
#20279
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/sas_service.go 512
go.sum 448 #20311
#19971
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/url_page_blob.go 446
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/url_blob.go 432
‼️ dashboard/assets/components/Footer.jsx 422 #19762
#20279
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_credential_shared_key.go 410
vendor/github.com/Azure/azure-sdk-for-go/LICENSE 404 #20311
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/service_codes_blob.go 390
‼️ vendor/github.com/Azure/azure-pipeline-go/pipeline/error.go 362 #20311
‼️ accounts/abi/bind/bind_test.go 332 #20244
#20311
#20381
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/url_block_blob.go 324
vendor/github.com/Azure/azure-pipeline-go/pipeline/doc.go 322 #20311
‼️ cmd/puppeth/genesis.go 320 #20241
#20339
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/parsing_urls.go 306 #20311
internal/build/download.go 298 #20295
vendor/github.com/Azure/azure-pipeline-go/pipeline/request.go 294 #20311
dashboard/system.go 292
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/url_service.go 290
‼️ dashboard/assets/components/Main.jsx 288 #19762
#20279
‼️ dashboard/assets/types/content.jsx 276 #19762
#20279
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_credential_token.go 274
‼️ miner/worker_test.go 266 #20268
#20219
#20310
#20375
‼️ build/ci.go 260 #20281
#20298
#20295
#20311
#20356
#20360
‼️ core/rawdb/accessors_chain.go 258 #20195
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/url_append_blob.go 256
p2p/discv5/ntp.go 252 #20367
‼️ dashboard/assets/components/SideBar.jsx 244 #19762
#20279
vendor/github.com/Azure/azure-sdk-for-go/README.md 204 #20311
metrics/ewma_test.go 202 #20219
p2p/discv5/table_test.go 198 #20367
dashboard/geoip.go 196
‼️ dashboard/message.go 192 #19762
‼️ dashboard/assets/common.jsx 184 #20279
‼️ core/helper_test.go 174 #20323
dashboard/assets/webpack.config.common.js 170 #20279
‼️ trie/database.go 168 #20366
#19971
‼️ dashboard/assets/components/CustomTooltip.jsx 168 #20279
vendor/github.com/Azure/azure-pipeline-go/pipeline/progress.go 164 #20311
‼️ dashboard/assets/components/Header.jsx 162 #19762
#20279
internal/build/gosrc.go 162 #20295
‼️ dashboard/assets/.eslintrc 162 #20279
‼️ p2p/metrics.go 160 #19762
‼️ miner/miner.go 156 #20310
#20375
vendor/github.com/Azure/azure-pipeline-go/pipeline/response.go 148 #20311
p2p/discv5/ticket.go 140 #20367
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/atomicmorph.go 138 #20311
‼️ rpc/json.go 136 #20289
#20332
go.mod 134 #20311
#19971
#20357
‼️ core/rawdb/accessors_chain_test.go 132 #20195
‼️ dashboard/assets/package.json 130 #19762
#20279
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/access_conditions.go 130 #20311
‼️ p2p/simulations/network_test.go 126 #20295
#20322
dashboard/assets/components/Body.jsx 126 #20279
‼️ cmd/puppeth/testdata/stureby_parity.json 122 #20241
‼️ vendor/github.com/Azure/azure-pipeline-go/pipeline/defaultlog_windows.go 122 #20311
‼️ dashboard/README.md 116 #20279
‼️ consensus/clique/api.go 116 #20316
#20103
metrics/sample_test.go 114 #20219
#20365
‼️ dashboard/assets/components/ChartRow.jsx 114 #20279
‼️ accounts/abi/bind/bind.go 112 #20244
#20381
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_credential_anonymous.go 110
‼️ les/clientpool_test.go 108 #20304
#20070
‼️ core/state/state_test.go 106 #20357
vendor/github.com/Azure/azure-sdk-for-go/glide.lock 106 #20311
‼️ cmd/clef/main.go 106 #20314
#20295
common/bytes_test.go 104 #20354
p2p/simulations/adapters/exec.go 100 #20289
#20322
‼️ core/state/dump.go 94 #20357
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_pipeline.go 92
.golangci.yml 90 #20295
p2p/discv5/net_test.go 88 #20367
‼️ dashboard/assets/index.jsx 88 #20279
‼️ internal/web3ext/web3ext.go 86 #20304
#20070
#20318
‼️ tests/state_test.go 84 #20338
dashboard/config.go 82
dashboard/assets/webpack.config.prod.js 82 #20279
vendor/github.com/Azure/azure-storage-blob-go/azblob/user_delegation_credential.go 76
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_mmf_windows.go 76
‼️ tests/block_test_util.go 76 #20364
accounts/abi/event_test.go 72 #20358
dashboard/cpu.go 70
dashboard/assets/webpack.config.dev.js 70 #20279
‼️ cmd/utils/flags.go 70 #19762
#20279
metrics/histogram_test.go 68 #20365
‼️ p2p/simulations/network.go 66 #20295
‼️ vendor/github.com/Azure/azure-pipeline-go/pipeline/defaultlog_syslog.go 66 #20311
‼️ rpc/client_test.go 64 #20332
metrics/timer_test.go 64 #20365
‼️ cmd/abigen/main.go 62 #20244
‼️ les/server.go 62 #20070
‼️ les/balance.go 56 #20304
#20070
‼️ rpc/service.go 56 #20332
signer/core/cliui.go 56 #20364
‼️ cmd/puppeth/genesis_test.go 54 #20241
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_mmf_unix.go 54
p2p/simulations/http.go 54 #20289
#20322
‼️ rpc/http.go 52 #20289
‼️ dashboard/assets/index.html 52 #20279
‼️ core/state/state_object_test.go 52 #20295
p2p/discv5/sim_test.go 50 #20367
p2p/discv5/database.go 50 #20367
p2p/discv5/node.go 50 #20367
common/main_test.go 50 #20354
core/state/main_test.go 50 #20357
‼️ accounts/abi/bind/template.go 48 #20381
‼️ core/types/block.go 48 #20355
p2p/discv5/net.go 46 #20367
dashboard/cpu_windows.go 46
‼️ dashboard/assets/fa-only-woff-loader.js 46 #20279
cmd/puppeth/ssh.go 46 #20350
‼️ internal/build/util.go 44 #20311
‼️ cmd/utils/customflags.go 44 #20295
metrics/registry_test.go 44 #20365
signer/rules/deps/bindata.go 42 #20364
vendor/github.com/Azure/azure-pipeline-go/LICENSE 42 #20311
vendor/github.com/Azure/azure-storage-blob-go/LICENSE 42 #20311
‼️ cmd/geth/config.go 42 #19762
#20279
‼️ .travis.yml 40 #20281
#20219
#20309
#20295
#20296
#20311
#20321
p2p/simulations/mocker_test.go 38 #20322
build/checksums.txt 38 #20295
build/clean_go_build_cache.sh 38 #20360
‼️ build/deb/ethereum/deb.rules 36 #20311
#20360
⚠️ cmd/faucet/faucet.go 36 #20283
‼️ p2p/enode/urlv4.go 34 #20252
‼️ p2p/server.go 34 #19762
#20325
‼️ p2p/discover/lookup.go 32 #20389
p2p/discv5/udp.go 32 #20367
‼️ crypto/ecies/ecies_test.go 32 #20295
‼️ core/blockchain_test.go 32 #20323
metrics/counter_test.go 32 #20365
‼️ rpc/subscription.go 32 #20289
#20332
‼️ p2p/simulations/http_test.go 32 #20295
‼️ cmd/geth/usage.go 30 #20279
‼️ rpc/testservice_test.go 30 #20332
vendor/github.com/Azure/azure-pipeline-go/pipeline/defaultlog.go 28 #20311
cmd/evm/runner.go 28 #20273
‼️ cmd/geth/main.go 28 #20279
‼️ rpc/types.go 26 #20289
#20332
‼️ rpc/doc.go 24 #20284
#20332
‼️ internal/ethapi/api.go 24 #20261
vendor/github.com/Azure/azure-sdk-for-go/glide.yaml 24 #20311
‼️ rpc/client.go 24 #20289
‼️ rlp/decode.go 24 #20295
#20368
‼️ rpc/handler.go 24 #20289
#20332
tests/init_test.go 22 #20364
‼️ dashboard/assets/.flowconfig 22 #20279
‼️ trie/trie_test.go 22 #20366
‼️ p2p/util.go 22 #20325
‼️ tests/transaction_test_util.go 22 #20337
#20364
p2p/rlpx.go 20 #20325
‼️ p2p/enode/urlv4_test.go 20 #20252
metrics/meter_test.go 20 #20365
crypto/bn256/bn256_fast.go 20 #20295
‼️ rpc/server.go 20 #20289
accounts/keystore/passphrase.go 18 #20373
‼️ rlp/decode_test.go 18 #20368
‼️ vendor/github.com/Azure/azure-pipeline-go/pipeline/version.go 18 #20311
‼️ common/types.go 18 #20354
‼️ core/state/statedb_test.go 18 #20357
‼️ core/rawdb/freezer_table_test.go 16 #20295
p2p/simulations/adapters/inproc.go 16 #20289
metrics/gauge_test.go 16 #20365
‼️ core/blockchain.go 16 #20295
#20355
core/asm/lex_test.go 16 #20362
metrics/sample.go 16 #20365
vendor/github.com/Azure/azure-storage-blob-go/azblob/storage_account_credential.go 16
p2p/discv5/table.go 16 #20367
metrics/runtime_test.go 16 #20365
‼️ miner/worker.go 14 #20310
‼️ core/forkid/forkid.go 14 #20295
event/feed.go 14 #20324
‼️ metrics/influxdb/influxdb.go 12 #20365
‼️ common/hexutil/json.go 12 #20353
‼️ .github/CODEOWNERS 12 #20329
eth/tracers/tracer.go 12 #20379
‼️ signer/core/api.go 10 #20364
metrics/librato/librato.go 10 #20365
‼️ internal/build/archive.go 10 #20295
cmd/wnode/main.go 10 #20327
‼️ core/vm/instructions_test.go 10 #20295
‼️ signer/storage/storage.go 10 #20364
metrics/timer.go 10 #20365
‼️ light/lightchain.go 10 #20318
cmd/evm/main.go 10 #20273
‼️ rpc/ipc.go 8 #20289
‼️ signer/core/api_test.go 8 #20364
‼️ les/client.go 8 #20318
‼️ signer/core/signed_data_test.go 8 #20295
‼️ core/state_transition.go 8 #20300
‼️ rpc/subscription_test.go 8 #20289
metrics/doc.go 8 #20219
p2p/discv5/README 8 #20367
‼️ rpc/websocket.go 8 #20289
‼️ rpc/inproc.go 8 #20289
mobile/android_test.go 8 #20311
⚠️ core/state/journal.go 8 #20357
dashboard/assets/.eslintignore 6 #20279
‼️ les/api_test.go 6 #20295
vendor/github.com/Azure/azure-storage-blob-go/azblob/version.go 6
p2p/simulations/events.go 6 #20295
p2p/simulations/adapters/types.go 6 #20289
‼️ core/chain_makers.go 6 #20323
p2p/dial.go 4 #19762
p2p/peer_test.go 4 #20277
core/vm/logger.go 4 #20294
cmd/ethkey/changepassword.go 4 #20313
metrics/gauge_float64_test.go 4 #20365
‼️ accounts/abi/abi_test.go 4 #20358
p2p/netutil/net.go 4 #20315
metrics/json_test.go 4 #20365
signer/rules/rules.go 4 #20364
‼️ les/protocol.go 4 #20295
consensus/ethash/ethash_test.go 4 #20219
‼️ rpc/websocket_test.go 4 #20332
‼️ eth/handler_test.go 4 #20219
‼️ Makefile 4 #20360
metrics/librato/client.go 4 #20365
‼️ rpc/server_test.go 4 #20289
‼️ signer/core/uiapi.go 4 #20364
‼️ signer/core/types.go 4 #20364
‼️ accounts/abi/bind/backends/simulated_test.go 4 #20359
p2p/nat/natpmp.go 4 #20295
core/asm/lexer.go 4 #20362
‼️ metrics/metrics.go 4
signer/core/stdioui.go 4 #20364
p2p/nat/nat.go 4 #20295
‼️ ethclient/ethclient.go 4 #20326
‼️ params/config.go 4 #20291
‼️ params/version.go 4
‼️ rpc/stdio.go 4 #20289
⚠️ .gitignore 2 #20295
‼️ cmd/geth/misccmd.go 2 #20385
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_models.go 0
vendor/github.com/allegro/bigcache/bigcache.go 0
vendor/github.com/allegro/bigcache/stats.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_sas_account.go 0
vendor/github.com/apilayer/freegeoip/AUTHORS 0
vendor/github.com/apilayer/freegeoip/CONTRIBUTORS 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_response_error.go 0
```` 0 #19762
vendor/github.com/allegro/bigcache/encoding.go 0
vendor/github.com/allegro/bigcache/entry_not_found_error.go 0
```` 0 #20289
vendor/github.com/allegro/bigcache/iterator.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_service_codes_common.go 0
```` 0 #20288
vendor/github.com/allegro/bigcache/clock.go 0
vendor/github.com/allegro/bigcache/queue/bytes_queue.go 0
```` 0 #20328
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_util_validate.go 0
vendor/github.com/allegro/bigcache/config.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_policy_unique_request_id.go 0
vendor/github.com/allegro/bigcache/utils.go 0
‼️ ```` 0 #20289
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_sas_query_params.go 0
vendor/github.com/allegro/bigcache/shard.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_page_blob.go 0
vendor/github.com/allegro/bigcache/logger.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_blob.go 0
vendor/github.com/allegro/bigcache/hash.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_service.go 0
vendor/github.com/allegro/bigcache/bytes_appengine.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_policy_request_log.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_append_blob.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_policy_retry.go 0
vendor/github.com/StackExchange/wmi/swbemservices.go 0
vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_retry_reader.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_block_blob.go 0
```` 0 #20289
vendor/github.com/allegro/bigcache/bytes.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_responder_policy.go 0
vendor/github.com/StackExchange/wmi/wmi.go 0
```` 0 #19762
#20279
```` 0 #20295
vendor/github.com/allegro/bigcache/LICENSE 0
‼️ ```` 0 #20289
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_version.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_policy_telemetry.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zt_doc.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_uuid.go 0
vendor/github.com/StackExchange/wmi/README.md 0
vendor/github.com/allegro/bigcache/README.md 0
```` 0 #20328
```` 0 #20289
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_container.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_validation.go 0
vendor/github.com/apilayer/freegeoip/HISTORY.md 0
vendor/github.com/allegro/bigcache/fnv.go 0
```` 0 #20288
vendor/github.com/apilayer/freegeoip/Dockerfile 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zc_storage_error.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_client.go 0
‼️ vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_response_helpers.go 0
vendor/github.com/StackExchange/wmi/LICENSE 0
```` 0 #20289

pdyraga and others added 30 commits August 21, 2019 13:09
The precompile at 0x09 wraps the BLAKE2b F compression function:
https://tools.ietf.org/html/rfc7693#section-3.2

The precompile requires 6 inputs tightly encoded, taking exactly 213
bytes, as explained below.

- `rounds` - the number of rounds - 32-bit unsigned big-endian word
- `h` - the state vector - 8 unsigned 64-bit little-endian words
- `m` - the message block vector - 16 unsigned 64-bit little-endian words
- `t_0, t_1` - offset counters - 2 unsigned 64-bit little-endian words
- `f` - the final block indicator flag - 8-bit word

[4 bytes for rounds][64 bytes for h][128 bytes for m][8 bytes for t_0]
[8 bytes for t_1][1 byte for f]

The boolean `f` parameter is considered as `true` if set to `1`.
The boolean `f` parameter is considered as `false` if set to `0`.
All other values yield an invalid encoding of `f` error.

The precompile should compute the F function as specified in the RFC
(https://tools.ietf.org/html/rfc7693#section-3.2) and return the updated
state vector `h` with unchanged encoding (little-endian).

See EIP-152 for details.
…f-precompile

core/vm, crypto/blake2b: add BLAKE2b compression func at 0x09
crypto/blake2b: fix non-amd64 builds
* core: log chain reorg/split metrics

* core: report 1-block reorgs on the metrics too
- Move the existing tests from memorydb into a generalized testsuite
that can be run by any ethdb backend implementation.
- Add several more test cases to clarify some non-obvious nuances when
implementing a custom ethdb backend, such as the behaviour of
NewIteratorWithPrefix vs NewIteratorWithStart.
- Add leveldb to the testsuite using in-memory storage for fast
execution.
build: gomobile automaticall adds the ios tag, don't duplicate
This copies cli.printHelp but changes minwidth to 38. Custom flag
code is improved to print the default value using cli.FlagStringer like
all built-in flags do.
This change adds support for gzip encoding on HTTP responses.
Gzip encoding is used when the client sets the 'accept-encoding: gzip' header.
Original change by @brianosaurus, with fixes from @SjonHortensius.
core/vm: enable istanbul EIPs in the jump table
cmd, core, eth, les: support --override.istanbul
* Change chainId in genesis block to 8888 from 0 

Change chainId in genesis block to 8888 from 0 per Moriteru in https://ethereum.stackexchange.com/a/28082/40230.

* Replace 8888 with “<arbitrary positive integer>”

Per PR review, replace Moriteru’s arbitrary positive integer 8888 with “<arbitrary positive integer>” in chainId field.
* les: wait all task routines before drop the peer

* les: address comments

* les: fix issue
eth: disallow overwrite files via admin.exportChain
internal/ethapi: implement fillTransaction
@ricardolyn ricardolyn marked this pull request as ready for review February 1, 2021 10:59
core/state_transition.go Outdated Show resolved Hide resolved
raft/handler_test.go Outdated Show resolved Hide resolved
rpc/server_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@nmvalera nmvalera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardolyn ricardolyn merged commit e854f8d into Consensys:master Feb 2, 2021
@ricardolyn ricardolyn changed the title Upgrade to geth 1.9.8 [Upgrade] Go-Ethereum release v1.9.8 Apr 6, 2021
@ricardolyn ricardolyn deleted the upgrade/quorum-geth-1.9.8 branch April 27, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet