Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/asm: allow numbers in labels #20362

Merged
merged 1 commit into from Nov 23, 2019

Conversation

@michaelforney
Copy link
Contributor

michaelforney commented Nov 21, 2019

Numbers were already allowed when creating labels, just not when
referencing them.

@fjl
fjl approved these changes Nov 22, 2019
@fjl

This comment has been minimized.

Copy link
Contributor

fjl commented Nov 22, 2019

Please add a test.

Numbers were already allowed when creating labels, just not when
referencing them.
@michaelforney michaelforney force-pushed the michaelforney:label-numbers branch from 0bf6382 to 372d4a7 Nov 22, 2019
@michaelforney

This comment has been minimized.

Copy link
Contributor Author

michaelforney commented Nov 22, 2019

Done

@fjl fjl added this to the 1.9.8 milestone Nov 23, 2019
@fjl fjl merged commit 3a0480e into ethereum:master Nov 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.