BLS tests: cover both implementations #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aces # Conflicts: # bls/src/main/java/tech/pegasys/teku/bls/BLS.java # bls/src/main/java/tech/pegasys/teku/bls/BLSPublicKey.java # bls/src/test/java/tech/pegasys/teku/bls/BLSPublicKeyTest.java # data/provider/src/main/java/tech/pegasys/teku/api/schema/BLSPubKey.java
# Conflicts: # bls/build.gradle # bls/src/test/java/tech/pegasys/teku/bls/impl/mikuli/hash2g2/ReferenceTests.java
…re and make them private
…BLSPublicKey fromSSZBytes() and fromBytesCompressed() though they are equivalent with current SSZ implementation
…Compressed() though they are equivalent with the current SSZ implementation
…S.aggregateSignatures() -> BLS.aggregate()
…-bls-tests # Conflicts: # bls/src/main/java/tech/pegasys/teku/bls/BLS.java # bls/src/test/java/tech/pegasys/teku/bls/BLSSecretKeyTest.java # bls/src/test/java/tech/pegasys/teku/bls/BLSTest.java
Nashatyrev
changed the title
The only other way I can think to implement would be to use
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Follow up to #2453
Make all
BLS*Testtesting bothMikuliandBlstimplementationsHonestly I don't like how this is implemented, so any JUnit hints on how to improve this solution are very appreciated
Documentation
documentationlabel to this PR if updates are required.