gradle: replace deprecated classifier property #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
StefanBratanov
approved these changes
Feb 17, 2023
The `classifier` property of `Jar` has been deprecated few major versions back, and no longer supported in the newest Gradle 8.0. Replace `classifier` with `archiveClassifier` as suggested in docs: https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.bundling.Jar.html#org.gradle.api.tasks.bundling.Jar:classifier Fixes Consensys#6825. Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
StefanBratanov
force-pushed
the
gradle-archive-classifier
branch
from
4c98cf7
to
2588c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
classifierproperty ofJarhas been deprecated few major versions back, and no longer supported in the newest Gradle 8.0. ReplaceclassifierwitharchiveClassifieras suggested in docs: https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.bundling.Jar.html#org.gradle.api.tasks.bundling.Jar:classifierPR Description
Fixed Issue(s)
Fixes #6825
Documentation
doc-change-requiredlabel to this PR if updates are required.This does not look applicable.
Changelog
This is not a breaking change so I did not consider this necessary; please let me know if this is needed.