Added electra validator index caching #8380
Draft
+208
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added performance test Altered some tests as we don't really want any of this functionality in deneb. It's gated currently on a state identifying as an electra state. The new performance test goes through unstable lookups only, so its good to compare against the ValidatorIndexCache which is the pre-electra implementation (and finalized generally) This may end up being not required, depending on some outstanding consensus spec changes. It should be noted cache misses in the non final range with 400k validators is a lot slower than it would be if the non final range wasn't the entire validator set. Signed-off-by: Paul Harris <paul.harris@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added performance test
Altered some tests as we don't really want any of this functionality in deneb. It's gated currently on a state identifying as an electra state. The new performance test goes through unstable lookups only, so its good to compare against the ValidatorIndexCache which is the pre-electra implementation (and finalized generally)
This may end up being not required, depending on some outstanding consensus spec changes. It should be noted cache misses in the non final range with 400k validators is a lot slower than it would be if the non final range wasn't the entire validator set.
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog