Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict to valid Argon2 algorithms only #531

Merged
merged 2 commits into from Nov 19, 2018
Merged

Restrict to valid Argon2 algorithms only #531

merged 2 commits into from Nov 19, 2018

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Nov 19, 2018

Throw an exception if an invalid Argon2 algorithm is encountered.
This is to ensure the user is aware that they are doing something improper and for them to correct it instead of doing something they may not want.

is to ensure the user is aware that they are doing something improper
and for them to correct it instead of doing something they may not want.
@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #531 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #531      +/-   ##
============================================
- Coverage     99.42%   99.41%   -0.01%     
+ Complexity     1257     1235      -22     
============================================
  Files           211      209       -2     
  Lines          3975     3927      -48     
  Branches        212      210       -2     
============================================
- Hits           3952     3904      -48     
  Misses            5        5              
  Partials         18       18
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/quorum/tessera/argon2/Argon2Impl.java 100% <100%> (ø) 8 <0> (+1) ⬆️
.../com/quorum/tessera/node/PartyInfoServiceImpl.java 100% <0%> (ø) 13% <0%> (ø) ⬇️
...in/java/com/quorum/tessera/api/ConfigResource.java 100% <0%> (ø) 5% <0%> (ø) ⬇️
.../quorum/tessera/config/keypairs/DirectKeyPair.java 100% <0%> (ø) 5% <0%> (ø) ⬇️
...main/java/com/quorum/tessera/node/model/Party.java 100% <0%> (ø) 6% <0%> (-1%) ⬇️
.../java/com/quorum/tessera/node/PartyInfoParser.java 100% <0%> (ø) 8% <0%> (-12%) ⬇️
...rum/tessera/config/keypairs/FilesystemKeyPair.java 100% <0%> (ø) 12% <0%> (ø) ⬇️
.../quorum/tessera/config/keypairs/InlineKeypair.java 100% <0%> (ø) 7% <0%> (ø) ⬇️
...sera/config/constraints/ValidContentValidator.java
.../quorum/tessera/node/PartyInfoParserException.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8fc88...052943b. Read the comment docs.

@prd-fox prd-fox merged commit c1e717b into Consensys:master Nov 19, 2018
@prd-fox prd-fox deleted the restrict-argon2-valid-algos branch November 19, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants