Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactional boundary issue for resend #898

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

namtruong
Copy link
Collaborator

@namtruong namtruong commented Oct 9, 2019

The transactional boundary was incorrectly set (via transactional annotation) at the TransactionManager method level (there was already one at the DAO layer).

In resend method, when recovery needs to be done for large datasets, due to db results pagination,
the resultSet was listed multiple times within this transactional boundary, which results in an increase in memory used that can potentially cause OutOfMemory exception

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #898   +/-   ##
=========================================
  Coverage     99.37%   99.37%           
  Complexity     2092     2092           
=========================================
  Files           317      317           
  Lines          5774     5774           
  Branches        309      309           
=========================================
  Hits           5738     5738           
  Misses            5        5           
  Partials         31       31
Impacted Files Coverage Δ Complexity Δ
...um/tessera/transaction/TransactionManagerImpl.java 100% <ø> (ø) 37 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2098f8...66eb0b5. Read the comment docs.

@melowe melowe merged commit 60336b9 into master Oct 10, 2019
@Krish1979 Krish1979 added the bug Something isn't working label Oct 10, 2019
@prd-fox prd-fox deleted the transactional-boundary-issue branch October 10, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.1 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants