Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CLI execution result handling #902

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Simplify CLI execution result handling #902

merged 1 commit into from
Oct 14, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Oct 13, 2019

Update PicoCLI dependency to latest release version.

Simplifies the retrieval of the CliResult from the execution of CLI args by gathering all executed subcommands and seeing if any had a result, picking the first (we only ever do at most 1 execution anyway).

Simplify the retrieval of the CliResult from the execution of CLI args
@codecov-io
Copy link

codecov-io commented Oct 13, 2019

Codecov Report

Merging #902 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #902      +/-   ##
============================================
- Coverage     99.37%   99.37%   -0.01%     
+ Complexity     2094     2092       -2     
============================================
  Files           318      318              
  Lines          5777     5776       -1     
  Branches        309      307       -2     
============================================
- Hits           5741     5740       -1     
  Misses            5        5              
  Partials         31       31
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/quorum/tessera/cli/CliDelegate.java 100% <100%> (ø) 10 <2> (-2) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d035e...106c652. Read the comment docs.

@Krish1979 Krish1979 merged commit a86fa6b into Consensys:master Oct 14, 2019
@prd-fox prd-fox deleted the simplify-cliresult-retrieval branch October 14, 2019 15:37
@Krish1979 Krish1979 added feature User features 0.10.1 labels Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.1 feature User features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants