Add key-config-path as preferred alias to key-store-path #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Changes units to use key-config-path as new default
siladu
added
the
doc-change-required
3 tasks
usmansaleem
reviewed
Jun 28, 2023
| final String key = stripPrefix(optionSpec.longestName()).replace("-", "_").toUpperCase(); | ||
| final String qualifiedKey = qualifiedPrefix + "_" + key; | ||
| return environment.get(qualifiedKey); | ||
|
|
There was a problem hiding this comment.
I think this is also coming through your other PR ... might cause merge conflict.
…lias Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
bgravenorst
removed
the
doc-change-required
|
Added to Doc backlog and removed label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Built on top of #825
Easier diff for this PR: siladu/web3signer@support-aliases...siladu:web3signer:key-config-path-alias
Fixed Issue(s)
#586
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing