Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /highWatermark endpoint #908

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Sep 11, 2023

Part of #696

GET http://127.0.0.1:9000/api/v1/eth2/highWatermark
returns either:

{
   "epoch": 1,
   "slot": 2
}

or empty json object when no high watermark set.

Allow epoch or slot to be null and respond with null string for that value (manual updates to DB can lead to this, even if high-watermark subcommand prevents it).

No automated tests for the endpoint in this PR as it will be tested as part of the overall subcommand acceptance test

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@siladu siladu added the TeamGroot Under active development by TeamGroot @PegaSys label Sep 11, 2023
@siladu siladu enabled auto-merge (squash) September 12, 2023 06:11
@siladu siladu merged commit b4a725d into Consensys:master Sep 12, 2023
7 checks passed
@siladu siladu deleted the get-highwatermarks-endpoint branch September 12, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamGroot Under active development by TeamGroot @PegaSys
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants