Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential error in Telco specification #634

Closed
samWighton opened this issue Mar 8, 2024 · 2 comments
Closed

Potential error in Telco specification #634

samWighton opened this issue Mar 8, 2024 · 2 comments
Assignees
@nils-work
Labels
Non-breaking change A change that is not expected to result in a new endpoint version. Proposal made The DSB has proposed a specific change to the standards to address the change request Telco
Milestone
v1.31.0

Comments

@samWighton
Copy link

samWighton commented Mar 8, 2024 •
edited by nils-work
Loading

In the Telco specification.

The 'TelcoAccountDetailResponseData' Schema is a combination of the three schemas

"#/components/schemas/TelcoAccountBase"
"#/components/schemas/TelcoAccount"
"#/components/schemas/TelcoAccountDetail"

This leads to multiple 'properties' called 'plans'.

Nils Berge mentioned that this may be an error.

In the case this is intentional, should a particular property take precedence ?

Thanks

DSB Proposed Solution

The proposed solution can be found through the staging link provided in this comment.
@nils-work nils-work added the Telco label Mar 8, 2024
@nils-work nils-work self-assigned this Mar 26, 2024
nils-work added a commit to ConsumerDataStandardsAustralia/standards-staging that referenced this issue Mar 26, 2024
@nils-work
Removed duplicate TelcoAccount schema
ada44fd 
Addresses: ConsumerDataStandardsAustralia/standards-maintenance#634
@nils-work
Copy link
Member

A change to address this issue has been staged for review here: ConsumerDataStandardsAustralia/standards-staging@release/1.30.0...maintenance/634

image

@nils-work nils-work added this to the v1.30.0 milestone Apr 2, 2024
@nils-work nils-work added the Proposal made The DSB has proposed a specific change to the standards to address the change request label Apr 2, 2024
@nils-work nils-work added the Non-breaking change A change that is not expected to result in a new endpoint version. label Apr 16, 2024
@nils-work nils-work removed this from the v1.30.0 milestone Apr 26, 2024
@nils-work nils-work added this to the v1.31.0 milestone May 20, 2024
@nils-work
Copy link
Member

A decision on this change was made with other items in Maintenance Iteration 18, but this issue was not included in version 1.30.0.
This issue will be included in the next release.

CDR-API-Stream added a commit to ConsumerDataStandardsAustralia/standards that referenced this issue Jul 3, 2024
@CDR-API-Stream @nils-work @HemangCDR
Release/1.31.0 (#354)
1cafb3e 
* 1.30.0 branch

* Updates to base build

* Update releasenotes.1.30.0.html.md

* Updated release notes templates

* Removed repeated object

* Removed duplicate TelcoAccount schema

Addresses: ConsumerDataStandardsAustralia/standards-maintenance#634

* Create clean 1.31.0 branch

* Expanded nested array structure for previousDays

Addresses: ConsumerDataStandardsAustralia/standards-staging#396

* Remove redundant TelcoAccount object

* Update releasenotes.1.31.0.html.md

* Enable generic links to schemas

Addresses: ConsumerDataStandardsAustralia/standards-staging#400

* Updated Consumer Data Right link

Addresses: ConsumerDataStandardsAustralia/standards-staging#402

* Updated Obligation Date Schedule

Addresses: ConsumerDataStandardsAustralia/standards-maintenance#615

* Removed title text

* Standards Maintenance Issue #640: Changed retirement date of Get Generic Plan Detail v2 and Get Energy Account Detail v3 to March 3rd 2025

* Standards Maintenance Issue #415: Clarified that a Token Introspection End Point response must include specific fields only for currently active tokens

* Standards Maintenance Issue #415: Corrected release notes change description

* Standards Maintenance Issue #415: Updated link to change in release notes

* Standards Maintenance Issue #415: Fixed spelling mistake in release notes

* Standards Maintenance Issue #633: Changes to CX and Security standards to clarify cdr_arrangement_id is requried for consent amendments

* Standards Maintenance Issue #633: minor presentation fixes

* Updated FDO table

Addresses: ConsumerDataStandardsAustralia/standards-staging#377

* Presentational styling of Banking documentation

Addresses: ConsumerDataStandardsAustralia/standards-staging#395

* Moved the March 2025 FDO to the 17th

* Standards Maintenance Issue #640: Moved release notes entry to Introduction section

* Standards Maintenance Issue #643: Allow data holders to depricate use of vulnerable TLS ciphers

* Standards Maintenance Issue #415: Made the word SHALL bold

* Fixed typo (#399)

Addresses: ConsumerDataStandardsAustralia/standards-staging#394

* Standards Maintenance Issue #643: Fixed typo in release notes

* Added MI19 DP link change log, re-ordered CRs in releasenotes

* In release notes, changed link to obligation date schedule for CR 615

* Build standards version 1.31.0 for staging

* Added change date in Change Log. Added None to release notes sections where there are no changes

* Rebuild version 1.31.0 in preparation of publishing

---------

Co-authored-by: Nils Berge <60594671+nils-work@users.noreply.github.com>
Co-authored-by: Hemang Rathod <hemang.rathod@consumerdatastandards.gov.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nils-work nils-work

Labels
Non-breaking change A change that is not expected to result in a new endpoint version. Proposal made The DSB has proposed a specific change to the standards to address the change request Telco
Projects
Data Standards Maintenance
Status: Done
Milestone
v1.31.0
Development

No branches or pull requests
2 participants
@samWighton @nils-work