Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Banking documentation #395

Open
nils-work opened this issue May 2, 2024 · 3 comments
Open

Enhancements to Banking documentation #395

nils-work opened this issue May 2, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@nils-work
Copy link
Member

The Banking Candidate Standards included a number of minor documentation enhancements that can be incorporated into the main Standards without changing meaning.
Aligning these changes would improve the binding Standards and make any comparison between the two versions more straightforward.

For example, the current statements:

  • Values can be OPEN, CLOSED or ALL. If absent then ALL is assumed
  • True if extended information is available using the transaction detail end point. False if extended data is not available

would become:

  • Values can be OPEN, CLOSED or ALL. If absent then ALL is assumed
  • true if extended information is available using the transaction detail endpoint. false if extended data is not available
@nils-work nils-work added the enhancement New feature or request label May 2, 2024
@nils-work nils-work added this to the v1.31.0 milestone May 3, 2024
@perlboy
Copy link

perlboy commented May 6, 2024

I question whether the description should have this sort of info in it. Does a boolean need an explanation? For the "if absent" parts it could be just as well served with the openapi default field as this is the implied value if the server does not receive a value from the client.

@nils-work
Copy link
Member Author

That's a good point @perlboy. Most Booleans do have simpler descriptions than that one though, and some have additional qualifying text for a default. We could consider simplifying as we go through, but would need to be more careful with any rewording to ensure the interpretation doesn't change and further guidance on specific fields is not needed.

Do you think changing this description for the isDetailAvailable Boolean:

True if extended information is available using the transaction detail end point. False if extended data is not available

to this, would be an improvement?:

Whether extended information is available using the transaction detail endpoint

Many Banking fields do have a default specified, but those values are not currently rendered to the documentation.
Do you think displaying them in a consistent way would be valuable? There is a handful of fields missing a default where it could be specified, and others describe a more complex default that may need to be considered, like:

If absent defaults to newest-time minus 90 days.

@nils-work
Copy link
Member Author

The changes incorporated with this issue include:

  • styling changes in descriptions:
    • italic where referring to field names
    • code where referring to field values
  • minor punctuation corrections and additions throughout as noted in Maintenance Issue #527
    • removed double spaces
    • added full-stops to sentences
    • changed 'end point' to 'endpoint'
  • minor formatting changes to improve readability
    • added links to enum detail
    • examples updated to use more common values (VARIABLE instead of BONUS, FIXED instead of BUNDLE_DISCOUNT_FIXED)
    • updates in descriptions including changing 'bonus' to BONUS and 'True' to true to show correct value form
  • alignment in formatting across the Banking API specification files:

Also note:

  • No changes have been made to specify default values as suggested, but these can be reviewed in future.
  • A number of minor typos will be addressed separately.
  • No change in the meaning of the Standards is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants