feat(proxy): Include a X-Cache Header #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
golangci-lint seems to have been failing for a while, also on the master branch |
Let's try to upgrade |
|
becareful, upgrading the |
Blokje5
force-pushed
the
feat/x-cache-header
branch
from
a6f4f4a
to
bb87411
Compare
mga-chka
approved these changes
Mar 8, 2023
proxy.go
Outdated
| @@ -457,7 +457,7 @@ func (rp *reverseProxy) serveFromCache(s *scope, srw *statResponseWriter, req *h | |||
|
|
|||
| rp.completeTransaction(s, statusCode, userCache, key, q, "") | |||
|
|
|||
| err = RespondWithData(srw, reader, contentMetadata, 0*time.Second, tmpFileRespWriter.StatusCode(), labels) | |||
| err = RespondWithData(srw, reader, contentMetadata, 0*time.Second, false, tmpFileRespWriter.StatusCode(), labels) | |||
There was a problem hiding this comment.
I wonder if in this case the value of the X-Cache header should be something else like N/A because even if it's a cache miss, it's something chproxy is not supposed to cache.
There was a problem hiding this comment.
That makes sense. I will push an update to this PR soon and introduce N/A.
Blokje5
force-pushed
the
feat/x-cache-header
branch
2 times, most recently
from
0e8bbf1
to
a51949d
Compare
…had a cache miss or hit. X-Cache will be set to HIT if a response came from the Cache, otherwise it will be set to MISS. Fixes ContentSquare#288 Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
Blokje5
force-pushed
the
feat/x-cache-header
branch
from
a51949d
to
db05b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
X-Cache will be set to HIT if a response came from the Cache, otherwise it will be set to MISS. As explained in the #288, this can help to determine the accuracy of the ClickHouse stats in the response (and there might be other use cases).
Fixes #288
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments