Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Templates type hints #1002

Merged
merged 3 commits into from Apr 27, 2022
Merged

Fix Templates type hints #1002

merged 3 commits into from Apr 27, 2022

Conversation

NickLucche
Copy link
Member

First draft attempting to fix #989

@coveralls
Copy link

coveralls commented Apr 26, 2022 •
edited

Pull Request Test Coverage Report for Build 2232140245

  • 18 of 20 (90.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 70.646%
Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/training/templates/online_supervised.py 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
avalanche/benchmarks/scenarios/classification_scenario.py 2 89.86%
Totals Coverage Status
Change from base Build 2202539813: -0.008%
Covered Lines: 12007
Relevant Lines: 16996
💛 - Coveralls

@AntonioCarta
Copy link
Collaborator

Thanks, just a minor comment and then we are ready to merge!

@NickLucche
Copy link
Member Author

nice

@AntonioCarta AntonioCarta merged commit e5562e3 into ContinualAI:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioCarta AntonioCarta AntonioCarta requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix type hints to make use of new benchmark structure
3 participants
@NickLucche @coveralls @AntonioCarta