Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apidoc improvements #1019

Merged
merged 6 commits into from May 16, 2022
Merged

apidoc improvements #1019

merged 6 commits into from May 16, 2022

Conversation

AntonioCarta
Copy link
Collaborator

  • Made some minor changes to docstrings to fix errors
  • added a small function that checks for classes missing from the apidoc
  • added a readme in docs for documentation for developers building the docs.

This was quite painful.

TODO: there are many classes that are not in the apidoc but should be. Let's try to add them before the next release.

@AndreaCossu can you do this check for the evaluation modules? also some of the descriptions may need to be updated.

@lrzpellegrini can you do it for the detection stuff?

read the doc for info on how to compile the doc without seeing tons of errors. Please try to not commit file with syntax errors.

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/benchmarks/datasets/endless_cl_sim/endless_cl_sim.py:274:81: E501 line too long (90 > 80 characters)
avalanche/benchmarks/datasets/endless_cl_sim/endless_cl_sim.py:277:81: E501 line too long (92 > 80 characters)
avalanche/training/supervised/strategy_wrappers.py:198:16: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:198:18: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:261:16: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:261:18: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:342:16: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:342:18: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:459:16: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:459:18: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:526:16: W605 invalid escape sequence '\*'
avalanche/training/supervised/strategy_wrappers.py:526:18: W605 invalid escape sequence '\*'
2       E501 line too long (90 > 80 characters)
10      W605 invalid escape sequence '\*'

@AntonioCarta
Copy link
Collaborator Author

@ggraffieti how can we silence pycodestyle on W605 warnings?

avalanche/training/supervised/strategy_wrappers.py:526:18: W605 invalid escape sequence '\*'

This is not an error, we need to escape * because it's a special character in the ReST markup.

@ggraffieti
Copy link
Member

ggraffieti commented May 12, 2022

You can edit the setup.cfg file in the main project directory and add warning W605 into the list of the ignored errors/warnings 👍

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2330539875

  • 9 of 29 (31.03%) changed or added relevant lines in 9 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 70.541%

Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/benchmarks/classic/clear.py 0 4 0.0%
avalanche/benchmarks/scenarios/exmodel_scenario.py 0 6 0.0%
avalanche/benchmarks/datasets/clear/clear.py 3 13 23.08%
Files with Coverage Reduction New Missed Lines %
avalanche/benchmarks/scenarios/exmodel_scenario.py 1 38.89%
avalanche/benchmarks/datasets/inaturalist/inaturalist.py 2 25.0%
avalanche/benchmarks/scenarios/classification_scenario.py 2 89.86%
Totals Coverage Status
Change from base Build 2296389316: -0.03%
Covered Lines: 12035
Relevant Lines: 17061

💛 - Coveralls

@AntonioCarta AntonioCarta merged commit b9f4514 into ContinualAI:master May 16, 2022
@AntonioCarta AntonioCarta deleted the docs_v2 branch May 16, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants