New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Depencencies #1043
Optional Depencencies #1043
Conversation
@AntonioCarta @NickLucche |
Pull Request Test Coverage Report for Build 2433873446
💛 - Coveralls |
Thanks, this looks perfect! The gym class stub was used just to avoid the error. Now that we have optional dependencies, we can remove it and emit the same error of the other packages when gym is not avaiable. |
Yep good work, we can run tests assuming all dependencies are installed right? Currently I'm checking for gym installation before skipping tests when testing rl_scenario, is there a better way to do it taking into account these changes? |
I don't think we have a better way than trying to import the dependency, catch the error and don't run the tests if the dependency is not present. I'll take a look at the tests but I think your solution is already the best one. |
…he "tests" directory
Oh no! It seems there are some PEP8 errors! 😕
|
pip install avalanche-lib[<group>]
, e.g.pip install avalanche-lib[detection]