Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Fix for OCL #1225

Merged
merged 3 commits into from Nov 29, 2022
Merged

Issue Fix for OCL #1225

merged 3 commits into from Nov 29, 2022

Conversation

HamedHemati
Copy link
Collaborator

  • FIX an issue with eval stream initialization
  • UPDATE interactive logger for online CL strategies

UPDATE interactive logger for online CL strategies
@coveralls
Copy link

coveralls commented Nov 25, 2022

Pull Request Test Coverage Report for Build 3569237018

  • 4 of 8 (50.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 73.754%

Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/logging/interactive_logging.py 1 5 20.0%
Totals Coverage Status
Change from base Build 3541326024: 0.02%
Covered Lines: 13646
Relevant Lines: 18502

💛 - Coveralls


if len(eval_streams) == 1:
self._eval_streams = eval_streams
else:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this inside_group_experiences_by_stream?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, sure.

@AntonioCarta
Copy link
Collaborator

can you add some tests to catch the error?

@HamedHemati
Copy link
Collaborator Author

can you add some tests to catch the error?

What do you mean by adding tests? is there something that needs to be caught?

@AntonioCarta
Copy link
Collaborator

What do you mean by adding tests? is there something that needs to be caught?

We need a unit test that fails if the bug with the OCL stream occurs again because of some changes.

@HamedHemati
Copy link
Collaborator Author

We need a unit test that fails if the bug with the OCL stream occurs again because of some changes.

The online strategy test is updated. Now, it checks assert cl_strategy.clock.train_exp_counter > 0 after training on the whole OCL stream.

@AntonioCarta
Copy link
Collaborator

Sorry, I didn't explain myself. This PR is fixing a bug:

FIX an issue with eval stream initialization

If we want to be sure the bug doesn't happen again, we need a unit test that checks this problem, i.e. passes an OCL eval stream and checks that the periodic eval groups the streams correctly in all the possible cases.

@AntonioCarta AntonioCarta merged commit 1c869d9 into ContinualAI:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants