New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue Fix for OCL #1225
Issue Fix for OCL #1225
Conversation
HamedHemati
commented
Nov 25, 2022
- FIX an issue with eval stream initialization
- UPDATE interactive logger for online CL strategies
UPDATE interactive logger for online CL strategies
Pull Request Test Coverage Report for Build 3569237018
💛 - Coveralls |
avalanche/training/templates/base.py
Outdated
|
||
if len(eval_streams) == 1: | ||
self._eval_streams = eval_streams | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put this inside_group_experiences_by_stream
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, sure.
can you add some tests to catch the error? |
What do you mean by adding tests? is there something that needs to be caught? |
We need a unit test that fails if the bug with the OCL stream occurs again because of some changes. |
The online strategy test is updated. Now, it checks |
Sorry, I didn't explain myself. This PR is fixing a bug:
If we want to be sure the bug doesn't happen again, we need a unit test that checks this problem, i.e. passes an OCL eval stream and checks that the periodic eval groups the streams correctly in all the possible cases. |