Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MIR potential infinite loop #1251

Merged
merged 9 commits into from Dec 13, 2022
Merged

Conversation

AlbinSou
Copy link
Collaborator

Fixed the infinite loop encountered in some scenarios.

That said, the behaviour of ER-MIR in domain-incremental is a bit weird since the way I implement it (initially thought for class incremental and also done by the authors), is that I remove current task classes from the replay.

But in domain incremental, all the classes are present all the time so replay should not happen if we follow this logic.

In definitive, the current version is not really adapted to domain incremental. The tests are running for now since the batch size is small enough so that all the classes do not appear in one batch, but it's just a fortunate event, should not be taken for granted for bigger batch sizes.

I also removed a useless function from ER_ACE PR

@AntonioCarta
Copy link
Collaborator

Thanks.

In general, users should be aware of each algorithm limitations. In the future, we can help them by triggering a warning in case of incompatible benchmark, like in this case.

@AntonioCarta AntonioCarta merged commit 217761e into ContinualAI:master Dec 13, 2022
@AlbinSou AlbinSou deleted the fix branch January 17, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants