Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the infinite loop encountered in some scenarios.
That said, the behaviour of ER-MIR in domain-incremental is a bit weird since the way I implement it (initially thought for class incremental and also done by the authors), is that I remove current task classes from the replay.
But in domain incremental, all the classes are present all the time so replay should not happen if we follow this logic.
In definitive, the current version is not really adapted to domain incremental. The tests are running for now since the batch size is small enough so that all the classes do not appear in one batch, but it's just a fortunate event, should not be taken for granted for bigger batch sizes.
I also removed a useless function from ER_ACE PR