Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OnlineObservation and Template Docstrings #1297

Merged
merged 5 commits into from Feb 13, 2023

Conversation

HamedHemati
Copy link
Collaborator

@HamedHemati HamedHemati commented Feb 8, 2023

This PR update template docstring and OnlineObservation.

The changes in the OnlineObersvation class now enable training models with dynamic modules in online strategies. Model adaptation is removed for each sub-experience, and instead, model adaptation and optimizer reset happen only in the boundary sub-experiences. Related to issue #1197.

@HamedHemati HamedHemati changed the title Template docstrings update Update OnlineObservation and Template Docstrings Feb 8, 2023
@AntonioCarta
Copy link
Collaborator

We cannot support dynamic models only in the boundary-aware setting. We should just do the model adaptation at every step in the boundary-free.

@HamedHemati
Copy link
Collaborator Author

Latest update:

  • Added necessary attributes for model adaptation after each sub-exp.
  • Re-added model adaptation for task-free streams.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4158245331

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 73.761%

Files with Coverage Reduction New Missed Lines %
avalanche/logging/text_logging.py 1 56.08%
avalanche/benchmarks/scenarios/classification_scenario.py 2 86.31%
Totals Coverage Status
Change from base Build 4134543518: -0.01%
Covered Lines: 13859
Relevant Lines: 18789

💛 - Coveralls

@AntonioCarta AntonioCarta merged commit 0088c30 into ContinualAI:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants