Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative Strategy and tests implemented #130

Merged
merged 7 commits into from
Oct 14, 2020
Merged

Cumulative Strategy and tests implemented #130

merged 7 commits into from
Oct 14, 2020

Conversation

AndreaCossu
Copy link
Collaborator

The cumulative strategy is created via a Cumulative Plugin. I used ConcatDatasetWithTargets on cumulative_training_sets() to merge multiple datasets.
The plugin override make_train_dataset in TrainingFlow.
I verified that the size of training set increases as the number of batches progresses.
I added tests for existing strategies.
Closes #127

@vlomonaco
Copy link
Member

Let me know when this is ready to be reviewed!

@AndreaCossu
Copy link
Collaborator Author

I implemented Cumulative as a strategy which extends Naive. Check it out 🤞
I verified that training size increases up to the total number of patterns in the last task.

@vlomonaco
Copy link
Member

are the acc results at the end of an MNIST Training good for each task? :)

@AndreaCossu
Copy link
Collaborator Author

I guess 😁 With 100 epochs and a SimpleMLP():

Computing accuracy on the whole test set
[Evaluation] Task 0: Avg Loss 0.005673463326126432; Avg Acc 0.8305262923240662
[Evaluation] Task 0: Avg Loss 0.005646013585128195; Avg Acc 0.8009523749351501
[Evaluation] Task 0: Avg Loss 0.004320864401375151; Avg Acc 0.8669999837875366
[Evaluation] Task 0: Avg Loss 0.0034416350111937115; Avg Acc 0.9095454812049866
[Evaluation] Task 0: Avg Loss 0.003999979075175434; Avg Acc 0.8945000171661377

@vlomonaco
Copy link
Member

Ok merging now

@vlomonaco vlomonaco merged commit b81f90c into ContinualAI:master Oct 14, 2020
vlomonaco pushed a commit that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cumulative Strategy
2 participants