New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cumulative accuracies #1339
Cumulative accuracies #1339
Conversation
Pull Request Test Coverage Report for Build 4936925152
💛 - Coveralls |
Hey Albin, thanks for the PR. Can you add some basic tests? Examples:
Just to be sure that the computation is working as expected. |
Yes, I will add some tests but also I'm trying to add the corresponding forgetting measure |
Added cumulative forgetting, I will add all the tests asap. There is one thing I wanted to comment, the way the cumulative accuracies are reported now is the following: CumulativeAccuracy/eval_phase/test_stream/Task000: 0.88 However, this can be a bit confusing since the task ID is never changing in class-incremental learning (always 0), but I still want to show the per-experience CumulativeAccuracy. Is this the correct way to do so or should I change it ? |
I would call them by exp, like |
I changed it, I also prefer it. |
cool, you just need to pull the master branch to fix the merge conflict. |
Adds the cumulative accuracy metric from "On the importance of cross-task features in class-incremental learning" https://arxiv.org/abs/2106.11930.
For now I only put the accuracies, maybe later I will add the forgetting metric derived from this accuracy metric.
I don't know if we should change the name a bit or not, I am afraid that it could be confounded with Average Anytime Accuracy that I know some works also call it similarly (like cumulative or accumulative accurracy).
I tested it on my baselines branch and checked that it worked, I'm still thinking of a nice unittest I could add.