Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffling dataset when updating GEM memory #1407

Merged
merged 2 commits into from Jun 8, 2023

Conversation

AndreaCossu
Copy link
Collaborator

Not shuffling the dataset has a large reduction in performance, since it may lead to an uneven distribution of samples per class within a task.
Using a class-balanced buffer would solve this. It is something we should consider for this kind of strategies.
For balanced datasets, this PR should fix the issue.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5209492297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.457%

Totals Coverage Status
Change from base Build 5189441884: 0.0%
Covered Lines: 16176
Relevant Lines: 22325

💛 - Coveralls

@AntonioCarta AntonioCarta merged commit 49e039b into ContinualAI:master Jun 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants