removed drop_last forwarding from make_eval_dataloader #1408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that, when calling
strategy.train(experience, eval_streams=[scenario.val_stream], drop_last=True)
The drop_last argument was used both in the training and in the evaluation dataloader. This is a quickfix to fix this behavior, it would be nice to find a better way of distinguishing kwargs that are forwarded to eval/train loaders, or even to functions outside of loaders.