Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed drop_last forwarding from make_eval_dataloader #1408

Merged
merged 1 commit into from Jun 8, 2023

Conversation

AlbinSou
Copy link
Collaborator

@AlbinSou AlbinSou commented Jun 8, 2023

Before that, when calling

strategy.train(experience, eval_streams=[scenario.val_stream], drop_last=True)

The drop_last argument was used both in the training and in the evaluation dataloader. This is a quickfix to fix this behavior, it would be nice to find a better way of distinguishing kwargs that are forwarded to eval/train loaders, or even to functions outside of loaders.

@AntonioCarta
Copy link
Collaborator

looks like test_cumulative_accuracy is failing again

@AlbinSou
Copy link
Collaborator Author

AlbinSou commented Jun 8, 2023

looks like test_cumulative_accuracy is failing again

I know and I still have no clue why ... Still works perfectly locally (contrarily to the topk test which fails locally in my case). If only I could reproduce the error locally that would help a lot.

@AntonioCarta
Copy link
Collaborator

please try to fix this. You can try to create the same env that we use in the CI by creating a fresh environment (or using the docker image we use for tests).

@AntonioCarta AntonioCarta merged commit b354713 into ContinualAI:master Jun 8, 2023
12 of 13 checks passed
@AlbinSou AlbinSou deleted the fix branch June 15, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants