turn ncm to dynamic module that adapts with 0 vectors at evaluation #1458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an adaptation at evaluation for NCM so that it fills class_means_dict with torch.zeros (default behavior for non-pre-existing classes).
Previously using eval_every=1 would fail unless all classes are present in the class_means_dict. Now it still fails for the first step (no classes in dict) since the feature size is unknown when no feature vectors are present. But it does not fail anymore for other steps.