Update clear_data.py #1545
Merged
Update clear_data.py #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download URL for clear10 and clear100 were updated as they were incorrect
|
Hi @viajeraune @AntonioCarta. Does the change make working correctly? It seems like it might conflict with |
|
Hello - yes once the change was merged, the dataset download has been
working successfully on my end. I'm not sure why it didn't work earlier.
Eunhae
…On Tue, Jan 9, 2024 at 8:03 AM Jaedong Hwang ***@***.***> wrote:
Hi @viajeraune <https://github.com/viajeraune> @AntonioCarta
<https://github.com/AntonioCarta>. Does the change make working
correctly? It seems like it might conflict with _dowlonad_dataset
function in CLEARDataset in here
<https://github.com/ContinualAI/avalanche/blob/39c097fde7953e1b4515efa42503421bcac4ba88/avalanche/benchmarks/datasets/clear/clear.py#L90C13-L90C47>
that appends base_url and name,
—
Reply to this email directly, view it on GitHub
<#1545 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5O7HKHB5FVY7EMWCOQM5DYNU5ZHAVCNFSM6AAAAABAG7IWCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGAZDQMJVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download URL for clear10 and clear100 were updated as they were incorrect