Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnn fix #882

Merged
merged 8 commits into from Jan 25, 2022
Merged

Pnn fix #882

merged 8 commits into from Jan 25, 2022

Conversation

AntonioCarta
Copy link
Collaborator

Fixes PNN eval adapatation.
Closes #876.

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

tests/training/test_strategies.py:426:13: E128 continuation line under-indented for visual indent
tests/training/test_strategies.py:427:13: E128 continuation line under-indented for visual indent
tests/training/test_strategies_accuracy.py:94:13: E128 continuation line under-indented for visual indent
tests/training/test_strategies_accuracy.py:95:13: E128 continuation line under-indented for visual indent
4       E128 continuation line under-indented for visual indent

@coveralls
Copy link

coveralls commented Jan 20, 2022

Pull Request Test Coverage Report for Build 1740726866

  • 1700 of 2168 (78.41%) changed or added relevant lines in 141 files are covered.
  • 92 unchanged lines in 38 files lost coverage.
  • Overall coverage increased (+0.04%) to 80.211%

Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/benchmarks/classic/cinaturalist.py 6 7 85.71%
avalanche/benchmarks/classic/openloris.py 4 5 80.0%
avalanche/benchmarks/datasets/omniglot.py 1 2 50.0%
avalanche/benchmarks/datasets/tiny_imagenet/tiny_imagenet.py 12 13 92.31%
avalanche/benchmarks/scenarios/generic_benchmark_creation.py 18 19 94.74%
avalanche/benchmarks/scenarios/lazy_dataset_sequence.py 11 12 91.67%
avalanche/benchmarks/scenarios/new_classes/nc_utils.py 7 8 87.5%
avalanche/evaluation/metrics/cpu_usage.py 2 3 66.67%
avalanche/evaluation/metrics/forgetting_bwt.py 19 20 95.0%
avalanche/evaluation/metrics/mac.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
avalanche/benchmarks/classic/ctrl.py 1 97.67%
avalanche/benchmarks/datasets/cub200/cub200.py 1 24.72%
avalanche/benchmarks/datasets/downloadable_dataset.py 1 67.05%
avalanche/benchmarks/datasets/openloris/openloris.py 1 17.31%
avalanche/benchmarks/datasets/tiny_imagenet/tiny_imagenet.py 1 77.78%
avalanche/benchmarks/generators/scenario_generators.py 1 24.72%
avalanche/benchmarks/scenarios/generic_definitions.py 1 85.37%
avalanche/benchmarks/scenarios/lazy_dataset_sequence.py 1 85.48%
avalanche/benchmarks/utils/data_loader.py 1 90.12%
avalanche/benchmarks/utils/datasets_from_filelists.py 1 38.41%
Totals Coverage Status
Change from base Build 1727860324: 0.04%
Covered Lines: 11730
Relevant Lines: 14624

💛 - Coveralls

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/benchmarks/datasets/mini_imagenet/mini_imagenet.py:273:39: E203 whitespace before ':'
avalanche/benchmarks/datasets/mini_imagenet/mini_imagenet.py:280:39: E203 whitespace before ':'
avalanche/training/plugins/agem.py:97:44: E203 whitespace before ':'
avalanche/training/plugins/cope.py:301:55: E203 whitespace before ':'
avalanche/training/plugins/gem.py:100:40: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:114:40: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:278:48: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:278:81: E501 line too long (81 > 80 characters)
avalanche/training/plugins/gss_greedy.py:282:48: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:282:81: E501 line too long (81 > 80 characters)
avalanche/training/plugins/gss_greedy.py:286:48: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:286:81: E501 line too long (81 > 80 characters)
avalanche/training/strategies/ar1.py:277:42: E203 whitespace before ':'
avalanche/training/strategies/ar1.py:283:42: E203 whitespace before ':'
avalanche/training/strategies/icarl.py:165:38: E203 whitespace before ':'
avalanche/training/strategies/icarl.py:237:34: E203 whitespace before ':'
avalanche/logging/text_logging.py:195:81: E501 line too long (85 > 80 characters)
tests/test_avalanche_dataset.py:1444:70: E203 whitespace before ':'
tests/test_avalanche_dataset.py:1447:70: E203 whitespace before ':'
tests/test_avalanche_dataset.py:1452:74: E203 whitespace before ':'
tests/test_avalanche_dataset.py:1456:70: E203 whitespace before ':'
tests/test_nc_mt_scenario.py:151:38: E203 whitespace before ':'
tests/test_nc_mt_scenario.py:189:38: E203 whitespace before ':'
tests/test_nc_sit_scenario.py:159:35: E203 whitespace before ':'
tests/test_nc_sit_scenario.py:219:35: E203 whitespace before ':'
tests/test_nc_sit_scenario.py:562:53: E203 whitespace before ':'
examples/icarl.py:54:23: E203 whitespace before ':'
examples/icarl.py:54:49: E203 whitespace before ':'
examples/icarl.py:58:23: E203 whitespace before ':'
examples/icarl.py:58:49: E203 whitespace before ':'
26      E203 whitespace before ':'
4       E501 line too long (81 > 80 characters)

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/benchmarks/datasets/mini_imagenet/mini_imagenet.py:273:39: E203 whitespace before ':'
avalanche/benchmarks/datasets/mini_imagenet/mini_imagenet.py:280:39: E203 whitespace before ':'
avalanche/training/plugins/agem.py:97:44: E203 whitespace before ':'
avalanche/training/plugins/cope.py:301:55: E203 whitespace before ':'
avalanche/training/plugins/gem.py:100:40: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:114:40: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:278:48: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:278:81: E501 line too long (81 > 80 characters)
avalanche/training/plugins/gss_greedy.py:282:48: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:282:81: E501 line too long (81 > 80 characters)
avalanche/training/plugins/gss_greedy.py:286:48: E203 whitespace before ':'
avalanche/training/plugins/gss_greedy.py:286:81: E501 line too long (81 > 80 characters)
avalanche/training/strategies/ar1.py:277:42: E203 whitespace before ':'
avalanche/training/strategies/ar1.py:283:42: E203 whitespace before ':'
avalanche/training/strategies/base_online_strategy.py:69:37: E203 whitespace before ':'
avalanche/training/strategies/icarl.py:165:38: E203 whitespace before ':'
avalanche/training/strategies/icarl.py:237:34: E203 whitespace before ':'
avalanche/logging/text_logging.py:195:81: E501 line too long (85 > 80 characters)
tests/test_avalanche_dataset.py:1444:70: E203 whitespace before ':'
tests/test_avalanche_dataset.py:1447:70: E203 whitespace before ':'
tests/test_avalanche_dataset.py:1452:74: E203 whitespace before ':'
tests/test_avalanche_dataset.py:1456:70: E203 whitespace before ':'
tests/test_nc_mt_scenario.py:151:38: E203 whitespace before ':'
tests/test_nc_mt_scenario.py:189:38: E203 whitespace before ':'
tests/test_nc_sit_scenario.py:159:35: E203 whitespace before ':'
tests/test_nc_sit_scenario.py:219:35: E203 whitespace before ':'
tests/test_nc_sit_scenario.py:562:53: E203 whitespace before ':'
examples/icarl.py:54:23: E203 whitespace before ':'
examples/icarl.py:54:49: E203 whitespace before ':'
examples/icarl.py:58:23: E203 whitespace before ':'
examples/icarl.py:58:49: E203 whitespace before ':'
27      E203 whitespace before ':'
4       E501 line too long (81 > 80 characters)

@AntonioCarta
Copy link
Collaborator Author

AntonioCarta commented Jan 21, 2022

great... I just discovered that pycodestyle is broken.
Also, black ignores this problem and therefore black-formatted code does not comply with pycodestyle.

@AntonioCarta AntonioCarta merged commit d13b1ea into ContinualAI:master Jan 25, 2022
@AntonioCarta AntonioCarta deleted the pnn_fix branch January 25, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some question Training on dynamic module PNN
3 participants