Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in CORe50 and openloris datasets #929

Merged
merged 2 commits into from Mar 9, 2022

Conversation

ggraffieti
Copy link
Member

@ggraffieti ggraffieti commented Mar 4, 2022

  • In both CORe50 and openloris, when the dataset were created with the field train=True the whole dataset is loaded (train + test set) and not only the train set as expected. Now with train=True only the training set is loaded.
  • In openloris only a portion of the dataset was loaded. Now the full dataset is loaded.

This PR fixes #928

- When the training set is loaded the whole dataset (train + test set) was loaded. Now it loads correctly the train set.
- Only a part of the dataset was loaded (the clutter scenario). Now the whole dataset is used
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1934810411

  • 0 of 10 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 77.873%

Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/benchmarks/datasets/core50/core50.py 0 1 0.0%
avalanche/benchmarks/datasets/openloris/openloris.py 0 9 0.0%
Totals Coverage Status
Change from base Build 1915821435: -0.02%
Covered Lines: 11628
Relevant Lines: 14932

💛 - Coveralls

@ggraffieti ggraffieti merged commit 3ab23fc into ContinualAI:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORe50Dataset return the whole dataset (train + test set) with the attribute train=True
2 participants