Skip to content

Commit

Permalink
clientupdate: return NOTREACHED for macsys (tailscale#8898)
Browse files Browse the repository at this point in the history
* clientupdate: return NOTREACHED for macsys

The work is done in Swift; this is now a documentation placeholder.

Updates tailscale#6995

Signed-off-by: Chris Palmer <cpalmer@tailscale.com>
Signed-off-by: Alex Paguis <alex@windscribe.com>
  • Loading branch information
Chris Palmer authored and alexelisenko committed Feb 15, 2024
1 parent 5300d64 commit f72fcad
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions clientupdate/clientupdate.go
Original file line number Diff line number Diff line change
Expand Up @@ -588,12 +588,7 @@ func parseAlpinePackageVersion(out []byte) (string, error) {
}

func (up *updater) updateMacSys() error {
// use sparkle? do we have permissions from this context? does sudo help?
// We can at least fail with a command they can run to update from the shell.
// Like "tailscale update --macsys | sudo sh" or something.
//
// TODO(bradfitz,mihai): implement. But for now:
return errors.ErrUnsupported
return errors.New("NOTREACHED: On MacSys builds, `tailscale update` is handled in Swift to launch the GUI updater")
}

func (up *updater) updateMacAppStore() error {
Expand Down

0 comments on commit f72fcad

Please sign in to comment.