New Version of PV Table with : 4.3.2 #1587
Conversation
- Table Export to Excel - New column Save TimeStamp (ablity to hide column with preference) - Configuration list with header #conf# - Multiple snapshot of configuration list called Measures
|
@kasemir can you review, thank you! |
|
org.csstudio.display.pvtable.test/.classpath changes org.eclipse.jdt.launching.JRE_CONTAINER to a specific SE1.7. We'd like to keep that as just JRE_CONTAINER. If the PVTable now needs org.apache.poi as indicated in the pom.xml, that should be added to the 3rd party module so it becomes part of the target platform. pv_table.xsd introduces a new element "nbMesure". All the existing XML elements are in English with underscores as separators. So maybe use "measurements" or "measure_count" or "number_of_measurements" instead of changing format and language. Can you fix these cosmetics, and then we merge. |
- classpath on MANIFEST.MF for pvtable and pavtable.test - extraction of librairies poi and xmlbeans : two plugins have been created for that : org.csstudio.platform.libs.poi and org.csstudio.platforms.libs.xmlbeans. Those plugins have been added to thirdparty features - Each words mesure have been replaced by measure. Internationalization of some sentences stay in French. - correction of pv_table.xsd file. Change nbMesure by measure_count.
|
Hello,
So, now I propose you two pull requets :
Can you confirm ? Thanks. |
|
Clarification on the external code for poi and xmlbeams: You could create new *poi and *xmlbeams plugins, add them to the 3rd party module as I had mentioned in my comment. Thinking about it once more, I assume what we really want is to simply "use" external code, if possible, by listing it in the maven-osgi-repo, so building that repo will pull the binaries from somewhere and we don't need to add copies of the binaries into our repos. Technically this means finding the *poi and *xmlbeams jar files in some maven repo so that the pom files in our maven-osgi-bundles module can wrap them as plugins. Or maybe the *poi and *xmlbeans code is already in some Eclipse orbit repo wrapped as a plugin? Eric @berryma4 knows more about this. If the *poi and *xmlbeans code is not in an existing maven or Eclipse repo, then yes, we need to put a copy into our cs-studio-thirdparty module. |
| <classpathentry exported="true" kind="lib" path="libs/poi-ooxml-schemas-3.13-20150929.jar"/> | ||
| <classpathentry exported="true" kind="lib" path="libs/poi-scratchpad-3.13-20150929.jar"/> | ||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/> | ||
| <classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/> |
There was a problem hiding this comment.
are any of these in orbit? If not, they should be added to the maven-osgi-bundles repo (which wraps artifacts from maven central into bundles and puts them into our p2).
| <groupId>org.apache.poi</groupId> | ||
| <artifactId>poi</artifactId> | ||
| <version>3.13</version> | ||
| </dependency> |
There was a problem hiding this comment.
could you move the dependencies to the manifest now that they are in the maven-osgi-bundles p2?
|
Hello,
|
|
How do you build your target platform? When I put http://.. into the IDE's target platform, I mostly get long delays and errors.
This compiles everything: Maven fetches dependencies from the remote repos. Depending on your luck, that can be slow or fail, but in the end, each compiled module has a P2 repository and all is local on your disk.
|
like asked by cs-studio community
|
Hi, `!ENTRY org.csstudio.display.pvtable 4 0 2016-02-25 14:41:06.423 Chain 1: Chain 2: Thanks for advises but it's a little more difficult when it's the first time. |
|
Status? |
|
Every thing is ok for me. I committed and pushed the last version. |
|
@kasemir , okay for merge? |
|
Charles Henry, thanks for following up on all the little things! Eric, I can't tell if all is fine with the POI code now in 3rd party or maven because my build has been broken with errors like these for a week: or They all seem related to BNL or channel code, so I'll wait for Kunal to return. Meanwhile, I'm OK with merging the table changes. |
New Version of PV Table with : 4.3.2
|
I get an error on jenkins: |
|
added #1642 |
|
typo in the word qualifier, I should have read the error more clearly. |
|
We have a few compile problems: https://openepics.ci.cloudbees.com/job/cs-studio-applications-display-master/44 |
#1515
First contribution of Spiral2 Project. Hope there will be plenty others.