Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added limits to the humid air properties, closes #1811 #1813

Merged
merged 1 commit into from Apr 2, 2019
Merged

Conversation

jowr
Copy link
Member

@jowr jowr commented Apr 1, 2019

Description of the Change

I introduced checks for the limits mentioned in https://doi.org/10.1080/10789669.2009.10390874

Use https://github.com/CoolProp/CoolProp/pull/1813/files?w=1 to ignore whitespace changes

Benefits

Calls that are out of bounds return an error and no longer give nonsense values.

Possible Drawbacks

Calls that are just slightly out of bounds will fail, but they might have worked before.

Applicable Issues

Closes #1811

@jowr jowr requested a review from ibell April 1, 2019 14:21
@ibell
Copy link
Contributor

ibell commented Apr 2, 2019

This looks good, and is a good idea that I should have done long ago. Conceptually I am struggling to see how one could run into trouble with this in the first place, but I see the point about the partial pressure being greater than the total pressure being a potential problem.

@ibell ibell merged commit b9ba76c into master Apr 2, 2019
@ibell
Copy link
Contributor

ibell commented Apr 2, 2019

One thing I was wondering about, should we skip the error check if the inputs are out of range but still technically possible? A negative mole fraction for instance would be an impossible state.

@jowr jowr deleted the issues/1811 branch May 15, 2019 19:12
@jowr jowr added this to the v6.3.0 milestone May 18, 2019
zmeri pushed a commit to zmeri/CoolProp that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Humid air properties above 388 K
2 participants