Never allow two-phase SOS. #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorade
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
In general, this is correct. The checking for two-phase should happen only once and the lowest level functions should just assume they are in a valid region, not sure what functions are called from where etc.
The same check can of course be done for other properties, e.g. how is cp currently handled?
PS: I used ?w=1 to ignore whitespace, then it is easier to review.
zmeri
pushed a commit
to zmeri/CoolProp
that referenced
this pull request
Mar 29, 2020
* Never allow two-phase SOS. Remove the ambiguity, and this is what REFPROP does. * More sensible checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ambiguity, and this is what REFPROP does.
Benefits
Correct thermodynamic behavior
Possible Drawbacks
A breaking change, might be surprising to users
Applicable Issues
#1836