Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash in PTflash_twophase::build_arrays #1881

Merged
merged 2 commits into from Apr 28, 2020

Conversation

tobias-loew
Copy link
Contributor

Fixed crash in SaturationSolvers::PTflash_twophase::build_arrays for mixtures with 3 or more components.

Requirements

  • Fill out this template to the extent possible so that this PR can be reviewed in a timely manner.
  • Replace the bracketed text below with your own.
  • All new code requires tests to ensure against regressions.

Description of the Change

changed used index

Benefits

code crashed hard because of wrong index

Possible Drawbacks

Verification Process

Please check, if numerical properties of algorithm are now correct

  • How did you verify that all new functionality works as expected?
  • How did you verify that all changed functionality works as expected?
  • How did you verify that the change has not introduced any regressions?

Describe the actions you performed (e.g. text you typed, commands you ran, etc.), and describe the results you observed.

Please attach here any python test sessions or image captures of testing in other wrappers. ]

Applicable Issues

Fixed crash in SaturationSolvers::PTflash_twophase::build_arrays for mixtures with 3 or more components.
@tobias-loew
Copy link
Contributor Author

tobias-loew commented Dec 18, 2019

There is still the problem in src/Backends/Helmholtz/FlashRoutines.cpp that with phase-envelope built ONLY single phase calculation are supported. This seems weird because WITHOUT phase-envelope two-phase calculation are at least tried!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants