Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.rst #1947

Merged
merged 3 commits into from Jun 15, 2020
Merged

Update index.rst #1947

merged 3 commits into from Jun 15, 2020

Conversation

MadsKirkFoged
Copy link
Contributor

Requirements

  • Fill out this template to the extent possible so that this PR can be reviewed in a timely manner.
  • Replace the bracketed text below with your own.
  • All new code requires tests to ensure against regressions.

Description of the Change

[ We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the wrapper code being implemented, so please walk us through the concepts. ]

Benefits

[ What benefits will be realized by the code change? ]

Possible Drawbacks

[ What are the possible side-effects or negative impacts of the code change? ]

Verification Process

[ What process did you follow to verify that your change has the desired effects?

  • How did you verify that all new functionality works as expected?
  • How did you verify that all changed functionality works as expected?
  • How did you verify that the change has not introduced any regressions?

Describe the actions you performed (e.g. text you typed, commands you ran, etc.), and describe the results you observed.

Please attach here any python test sessions or image captures of testing in other wrappers. ]

Applicable Issues

[ Enter any applicable Issues here. Use Closes #???? if this PR closes an open issue. ]

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2020

CLA assistant check
All committers have signed the CLA.

@ibell
Copy link
Contributor

ibell commented Jun 11, 2020

Could you possibly provide the URL to your library? Also highlight that SharpFluids is using CoolProp behind the scenes, if that is in fact true?

Added link and short description
@MadsKirkFoged
Copy link
Contributor Author

I have added a short description and a link to its Github

Console.WriteLine("Density of water at 13°C: " + Water.RHO);
Console.ReadLine();

- Press '5F' or 'Start' to check that it is working
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be F5 instead of 5F?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right it should be 'F5'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ibell ibell merged commit 0fac1aa into CoolProp:master Jun 15, 2020
@jowr jowr added this to the v6.4.1 milestone Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants