Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The changes in #1990 require C++11 compiler support. On macOS 10.14 with
XCode 11.3, the -std=c++11 flag must be specified to the compiler.
I was getting errors when compiling like:
Benefits
Fix this compiling error on macOS
Possible Drawbacks
This should only affect macOS, but I haven't tested on newer versions of macOS than 10.14, so I'm not sure if this is required for newer versions of XCode.
Verification Process
I built the Python wrapper on macOS 10.14, as well as used CMake to build the shared libraries.
Applicable Issues
#1990 introduced this change to strings.