A minor correction in case of COOLPROP_OBJECT_LIBRARY=ON #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
A minor correction of CMakeList.txt is done to suppress the configuration error in case of COOLPROP_OBJECT_LIBRARY=ON, which is a switch to build the objects, usually, required to build the ExternalMedia library in OpenModelica; what is done is just skipping the trouble spot of target_link_libraries for dl library in such a case.
Benefits
Solving the configuration error during the build-process of libExternalMedia.a for the ExternalMedia package.
Possible Drawbacks
N/A
Verification Process
All the options of COOLPROP_OBJECT_LIBRARY, COOLPROP_SHARED_LIBRARY, and COOLPROP_STATIC_LIBRARY are checked in independent manner. After then, the make-process of the ExternalMedia library is also tested chaining the cmake project with COOLPROP_OBJECT_LIBRARY=ON.
Applicable Issues
Closes #2010 if this PR closes an open issue.