New functions for CoolPropLib #2133
Conversation
|
What is the relationship between this PR and #2135 ? Should this be merged or closed? |
|
Both should be merged. I wanted to separate high-level and low-level functions (although I just realised #2135 has a high-level function as well...). Can join both PRs into one, if preferred. |
|
My preference is to separate the low-level and high-level changes (PR should be quite granular, and do one thing only, within reason). I will merge this one. |
|
Glad I thought about this, please refactor to move implementation into |
I'm sorry, I don't understand, what should I refactor? Props1SImulti is implemented in src/CoolProp.cpp |
Props1SImulti new function in CoolProp
friederikeboehm
force-pushed
the
props1SImulti
branch
from
caab4f1
to
fd010d3
Compare
|
The function should be implemented in |
| throw CoolProp::ValueError( | ||
| format("Length of fractions vector [%d] is not equal to length of fluidNames vector [%d]", _fluidNames.size(), length_fractions)); | ||
| std::vector<double> _fractions(fractions, fractions + length_fractions); | ||
| std::vector<std::vector<double>> _result = CoolProp::Props1SImulti(_outputs, backend, _fluidNames, _fractions); |
There was a problem hiding this comment.
Call to CoolProp::Props1SImulti
I thought that's exactly what I did? In CoolProp.cpp I implemented Props1SImulti and in CoolPropLib.cpp I call that function (and do a lot of error handling). I added comments at the according code changes in CoolProp.cpp and CoolPropLib.cpp. Please tell me, what I need to change as I don't understand what's wrong with my code. |
|
Sorry, I didn't read closely enough before |
Props1SImulti new function in CoolProp
Props1SImulti new function in CoolProp and Props1SImulti and PropsSImulti to CoolPropLib
Description of the Change
Function Props1SImulti was added to CoolProp. It is the Props1SI function but with multiple outputs possible, comparable to PropsSImulti.
Props1SImulti and PropsSImulti were added to CoolPropLib
Benefits
Enables the user to acces multiple non-thermodynamic-state-dependend fluid properties at once.
Possible Drawbacks
None
Verification Process
Functions were tested using the Mathematica wrapper, see PR #2085