Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cyclopentane.json #2225

Merged
merged 1 commit into from Mar 22, 2023
Merged

update cyclopentane.json #2225

merged 1 commit into from Mar 22, 2023

Conversation

longemen3000
Copy link
Contributor

Requirements

  • Fill out this template to the extent possible so that this PR can be reviewed in a timely manner.
  • Replace the bracketed text below with your own.
  • All new code requires tests to ensure against regressions.

Description of the Change

Updates the Cyclopentane JSON data to add use the reference equation in http://dx.doi.org/10.1021/je5010164

Benefits

should solve #2051

Applicable Issues

closes #2051

@longemen3000
update cyclopentane.json
f3ba899 
following the suggestion on CoolProp#2051
@CLAassistant
Copy link

CLAassistant commented Mar 21, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@ibell
Copy link
Contributor

ibell commented Mar 22, 2023

Thank you! Is the entry in the BibTeX file also updated?

@longemen3000
Copy link
Contributor Author

I don't think so, let me check and update if necessary

@longemen3000
Copy link
Contributor Author

the bibtex entry (Gedanitz-JCED-2015) seems correct

@ibell
Copy link
Contributor

ibell commented Mar 22, 2023

So we're good to go with this then?

@ibell ibell merged commit abcb4a5 into CoolProp:master Mar 22, 2023
@longemen3000 longemen3000 deleted the patch-1 branch March 22, 2023 02:30
@ibell ibell added this to the v6.5.0 milestone Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.5.0
Development

Successfully merging this pull request may close these issues.

Cyclopentane EOS needs to be updated
3 participants
@longemen3000 @CLAassistant @ibell