Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch singular explosions in saturation_PHSU_pure #2250

Merged
merged 6 commits into from
Jan 16, 2024

Commits on May 10, 2023

  1. Catch singular explosions in saturation_PHSU_pure

    Sometimes, the Akasaka solver has issues. This is usually caught and
    then it is retried with a new omega. However, sometimes it goes bad
    because the J matrix is singular, and this is not caught because the
    error is not recalculated.
    
    This commit recalculates the error term to prevent a bad result.
    msaitta-mpr committed May 10, 2023
    Configuration menu
    Copy the full SHA
    41739c5 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Configuration menu
    Copy the full SHA
    c1dc498 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Add extra update check after saturation_PHSU_pure

    During saturated PHSU flash calculations, SatL and SatV states have an
    imposed phase. This is good for stability, but there is a small chance
    that they can both up up with a matching third variable (e.g.,
    pressure) that is not actually at the saturation point. This commit
    forces a final DT update without this requirement. If an actual solution
    has been found, the the error term will still be small. If not, then we
    throw an exception and try again.
    
    This continues work on CoolProp#2245.
    msaitta-mpr committed May 26, 2023
    Configuration menu
    Copy the full SHA
    f249f3f View commit details
    Browse the repository at this point in the history
  2. Ensure that saturated phase is specified

    In saturation_PHSU_pure, we unspecify the phase of SatL and SatV to
    perform a final check. However, for any future updates, these states
    *must* be set with specified phase. This commit ensures that no matter
    what happens (exception, etc.) the phase is always specified again.
    msaitta-mpr committed May 26, 2023
    Configuration menu
    Copy the full SHA
    c6b650b View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Revert "Ensure that saturated phase is specified"

    This reverts commit c6b650b.
    
    The commit caused potential recursive lookups and did not solve the
    issue at hand.
    msaitta-mpr committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1331b4d View commit details
    Browse the repository at this point in the history
  2. Update the ammonio saturated rhoV ancillary

    The rhoV ancillary gave somewhat wrong results. This commit provides a
    closer fit that prevents errors downstream.
    msaitta-mpr committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    475e5b3 View commit details
    Browse the repository at this point in the history