Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug introduced by 443a2fd #2351

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Commits on Feb 16, 2024

  1. Fix bug introduced by 443a2fd

    Commit 443a2fd addedsome extra checks for convergence in the Helmholtz
    PHSU flash routines. However, its checking was more aggressive than the
    original routine. This caused the routine to raise an exception on
    several values that had previously been deemed acceptable. This trickled
    down to cause the TTSE tables to be filled with empty values, making
    them less robust.
    
    This commit allows for a solution to be acceptable if the change is
    small between iterations as was originally intended.
    msaitta-mpr committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    6e6a80a View commit details
    Browse the repository at this point in the history