Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correction instanciation playerJW js by adding handleOnPlay #1439

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

silouone
Copy link
Member

Detailed purpose of the PR

The was a reggression with the new player in staging , this fix allow to re-establish the onPlay on the videoPlayer components.

Result and observation

  • Breaking changes ?
    If checked, what have you broken ?

  • Extra lib ?
    If checked, Which extra lib did you add ? (name, purpose, link ...).

Testing Strategy

  • Already covered by tests
  • Manual testing
  • Unit testing

@jomaora jomaora merged commit a6f2592 into master Jan 18, 2019
@jomaora jomaora deleted the fix-OnPlay-VideoPlayer branch January 18, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants