Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 Support #497

Merged

Conversation

gnat42
Copy link
Contributor

@gnat42 gnat42 commented Aug 25, 2022

This adds supports for PHP 8.1

@gnat42
Copy link
Contributor Author

gnat42 commented Aug 25, 2022

This is based on top of the PR for 8.0 rebased on top of the latest upstream master

@rcdevs
Copy link

rcdevs commented Jan 2, 2023

The patch is incomplete and does not handle params by reference:

in ./zend/callable.h
the types' assignment code like:

case Type::String: info->type = (zend_type) ZEND_TYPE_INIT_CODE(IS_STRING, arg.allowNull(), 0);

should be:

case Type::String: info->type = (zend_type) ZEND_TYPE_INIT_CODE(IS_STRING, arg.allowNull(), _ZEND_ARG_INFO_FLAGS(arg.byReference(), 0, 0));

@gnat42
Copy link
Contributor Author

gnat42 commented Jan 2, 2023

Nice catch. I've added the code (to more than just the string type parameter) I also found a php8.2 PR in a fork of this that also fixed another issue with my original php80 PR. Both of changes are in the original PHP8.0 PR since that's where it was changed and the original PR hasn't been merged.

@carlos-granados
Copy link

This has been merged into a maintained fork here: fast-debug#12

@EmielBruijntjes EmielBruijntjes merged commit a5d9014 into CopernicaMarketingSoftware:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants