Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply naming conventions #43

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Apply naming conventions #43

merged 1 commit into from
Nov 8, 2023

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Nov 8, 2023

  • The relayer address in the XRPL and coreum should be called RelayerXRPLAddress, RelayerCoreumAddress
  • The bridge address should be called BridgeXRPLAddress
  • Use save action name for evidence and signatures
  • Rename TicketNumber -> TicketSequence, SequenceNumber -> AccountSequence, UsedTicketsThreshold -> UsedTicketSequenceThreshold
  • Use Origin word instead of Native for tokens

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

* The relayer address in the XRPL and coreum should be called `RelayerXRPLAddress`, `RelayerCoreumAddress`
* The bridge address should be called `BridgeXRPLAddress`
* Use `save` action name for evidence and signatures
* Rename `TicketNumber` -> `TicketSequence`, `SequenceNumber` -> `AccountSequence`, `UsedTicketsThreshold` -> `UsedTicketSequenceThreshold`
* Use `Origin` word instead of `Native` for tokens
@dzmitryhil dzmitryhil requested a review from a team as a code owner November 8, 2023 09:08
@dzmitryhil dzmitryhil requested review from miladz68, ysv and wojtek-coreum and removed request for a team November 8, 2023 09:08
Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35 of 35 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68, @wojtek-coreum, and @ysv)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35 of 35 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

@dzmitryhil dzmitryhil merged commit 1d2b542 into master Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants