Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CorfuTable getByIndexAndFilter logging #1030

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Conversation

zalokhan
Copy link
Member

@zalokhan zalokhan commented Dec 1, 2017

Overview

Description: Change CorfuTable getByIndexAndFilter logging from WARN to DEBUG.

Why should this be merged: CorfuTable can now be used with a single index only, so emitting a warn message is excessive.

Checklist (Definition of Done):

  • There are no TODOs left in the code
  • Coding conventions (e.g. for logging, unit tests) have been followed
  • Change is covered by automated tests
  • Public API has Javadoc

@zalokhan zalokhan self-assigned this Dec 1, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 70.591% when pulling 130ad13 on zalokhan:logging into 403a8d9 on CorfuDB:master.

@corfudb-performance
Copy link
Collaborator

Results automatically generated by CorfuDB Benchmark Framework to assess the performance of this pull request for commit 130ad13.

*** 0.03333333333333333% transaction FAILURE rate for NonConflictingTx+Scan workload, 1 threads, Disk mode
*** 0.49166666666666664% transaction FAILURE rate for NonConflictingTx+Scan workload, 5 threads, Disk mode
*** 0.4666666666666667% transaction FAILURE rate for NonConflictingTx+Scan workload, 10 threads, Disk mode
*** 0.03333333333333333% transaction FAILURE rate for NonConflictingTx+Iterator workload, 1 threads, Disk mode
*** 1.1416666666666666% transaction FAILURE rate for NonConflictingTx+Iterator workload, 5 threads, Disk mode
*** 1.875% transaction FAILURE rate for NonConflictingTx+Iterator workload, 10 threads, Disk mode
*** 0.0% transaction FAILURE rate for NonConflictingTx workload, 1 threads, Disk mode
*** 0.0% transaction FAILURE rate for NonConflictingTx workload, 5 threads, Disk mode
*** 0.0% transaction FAILURE rate for NonConflictingTx workload, 10 threads, Disk mode

An interactive dashboard with Pull Request Performance Metrics for ALL cluster types and numbers of threads in run, is available at:
Pull Request #1030 Graphs

Copy link
Member

@no2chem no2chem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Check the boxes in the pull request form. We should add a "Why should this be merged" field to the overview as well to add some background.

@zalokhan
Copy link
Member Author

zalokhan commented Dec 1, 2017

Yes, I've checked them.
"Why should this be merged" would be good to have in case there is no pending github issue.

@no2chem no2chem merged commit 5aa1eb0 into CorfuDB:master Dec 1, 2017
@no2chem
Copy link
Member

no2chem commented Dec 1, 2017

Great. I've added that to the PR, and will add it to the template now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants