Fix and improve highlighting of independent fields and TVs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s individually, so when the &showExtract property if the AdvSearch snippet contains multiple fields and TVs they are examined independently. This help to avoid multiple issues. E.g. &showExtract=`3:content,pagetitle`, and there's a search term match at the beginning of the pagetitle, the extract would show the end of content concatenated to the beginning of the pagetitle, also worse, if the ending of content concatenated with the beginning of pagetitle create a match, it'd be shown as a highlight, while in reality none of the two has a match.
BenceSzalai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: The extracts are searched and extracted from each resource fields individually, so when the &showExtract property of the AdvSearch snippet contains multiple fields and TVs they are examined independently. This help to avoid multiple issues. E.g.
&showExtract=`3:content,pagetitle`, and there's a search term match at the beginning of the pagetitle, the extract was showing the end of content concatenated to the beginning of the pagetitle, also worse, if the ending of content concatenated with the beginning of pagetitle created a match, it was shown as a highlight, while in reality none of the two has a match.