Fix: One column of pixels means 4 skip bytes in 32bpp. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think this deserves a comment? |
|
Or a const like RGBA_BYTES_PER_PIXEL. I would really like to reduce the number of undocumented magic numbers. |
Alberth289346
force-pushed
the
fix_cropping_offset
branch
from
badb401
to
3e95e52
Compare
|
Good idea, fixed. I find it confusing that some doxymentation must be in the .h file, and others (of static members, and local constants) must be in .cpp. It's hard to see whether everything is documented. The doxymentation style is also hard to type (//! for the first line, /*! .. */ for the other text), I don't really see the purpose of that. Simplifying it would be welcome. |
Alberth289346
force-pushed
the
fix_cropping_offset
branch
from
0f479ed
to
09f653b
Compare
TheCycoONE
added a commit
that referenced
this pull request
Sep 7, 2015
Fix: One column of pixels means 4 skip bytes in 32bpp.
|
Sorry, forgot about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cropping removes columns of pixels, but a column is 4 channels wide in RGBA.
Tested by sadger, confirmed to be working for 1 removed column at the left.