[Bug] Unicode language text is drawn a few pixels off target

[tobylane]

Describe the issue

The text from the Unicode languages (eg Korean) are 2 pixels off where they should be. In the first screenshot of the Build Room dialog they are down and right of the English screenshot, but in the Graphs dialog and bottom panel, they are up and left.

Steps to Reproduce

1. Switch to a unicode font and load/start a game

2. Open the dialogs Build Room, Hire Staff, Progress Report, Graphs

Expected Behaviour

Consistent placement

Save Game

Save game attached to report: Yes/No

CorsixTH Version

15368f1 (recent master)

Operating System

macOS 10.15

Theme Hospital Version

CD

Gamelog.txt

No response

Additional Information

[TheCycoONE]

This is because the font is taller isn't it?

[Alberth289346]

Pasted both closer to each other (vertically aligned on the buttons), added some red marker lines for comparison, and enlarged the editor view to get more detail:

Bottom sticks out from the button by 3 pixels, and skips the first 4 pixels.

Note that English is not vertically centered either:

The top 5 pixels in a button are not used in the screen shot by Toby, for English. The title doesn't use the top 4 pixels. Moving up by 2-3 pixels looks like it should work in this case,

---

For the general case, a more robust solution could be to also supply size information of the text, so the code can exactly center it,

[lewri]

I'm guessing we draw font specifying the top left pixel position. Not very wise it seems for anything but built-in

[Alberth289346]

Fonts are designed to look good when you fill a page / screen with text.

Different fonts have different amounts of space around the letters. Some of that space is used for getting the good distance between 2 consecutive lines of text (which we don't need here).

Other space is used by just a few "high" or "low" letters. If you happen not to use those, the empty space looks like a needless huge gap.

[TheCycoONE]

Lewri is right here. Also not all fonts are the same aspect ratio. Sounds like this bug might be about choosing size better