New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable demo movie #2340

Merged

TheCycoONE merged 1 commit into CorsixTH:master from lewri:demomovie_disable

May 22, 2023

Member

lewri commented May 21, 2023

Describe what the proposed change does

As some people may find the demo movie playback annoying a config option has been added to disable just that element.


          Add option to disable demo movie

93a8438

lewri added the PR:Improvement label

lewri added this to In progress in 0.67 Release via automation

Member Author

lewri commented May 21, 2023 •

edited

Personally I like having the intro play, but not as much the demo, which is why this PR exists.
Alternatives to this:

Expand the wording of the play_intro config option and assume user either wants both enabled or both disabled (not effective on existing configs as the text won't be rewritten unless a config option is missing).
Write the app.lua check as if not self.config.play_intro or not self.config.play_demo, assume intro disablers don't want demo either. Also gives compatibility with old config options.

TheCycoONE merged commit e2485ff into CorsixTH:master

5 checks passed

0.67 Release automation moved this from In progress to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment