Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing initial in staff names #2555

Merged
merged 1 commit into from Apr 17, 2024
Merged

Conversation

tobylane
Copy link
Member

Fixes #2554

Describe what the proposed change does

  • When the number used to pick a staff initial is 0, make it 1. Apply this to existing staff.

@TheCycoONE
Copy link
Member

I think the proper fix here is + 1, otherwise no one gets the last entry and the first is twice as often. To preserve existing names the table can be shifted.

@lewri lewri added this to In progress in 0.68 Release via automation Apr 14, 2024
@tobylane
Copy link
Member Author

The last entry, which is never used, is copied to the 0th position. This keeps the order and fills the initials table the way it's needed, from 0.

@TheCycoONE
Copy link
Member

Yeah that works.

@TheCycoONE TheCycoONE merged commit b84b323 into CorsixTH:master Apr 17, 2024
4 of 5 checks passed
0.68 Release automation moved this from In progress to Done Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
0.68 Release
  
Done
Development

Successfully merging this pull request may close these issues.

[Bug] Doctor has "%s" for first name initial
3 participants