Games are now always paused when the award screen appears #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously games would only be paused when the game speed was set to "Speed Up".
TheCycoONE
added a commit
that referenced
this pull request
Jul 22, 2014
Games are now always paused when the award screen appears
|
For me if you are using the speedup key when the award screen opens then once you close it the game is running fast and the speedup key becomes a pause key! |
|
In world:setSpeed it records the current speed so that when you unpause or unspeedup it can return to it. The problem is we're entering two temporary states, both speedup and pause. I think it shouldn't overwrite the current speed when the game is currently Paused or SpeedUp. Anyway this can be a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously games would only be paused when the game speed was set
to "Speed Up".
Fixed issue: #286