Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cvm runtime submodules to go modules #732

Merged
merged 10 commits into from Aug 13, 2020
Merged

Cvm runtime submodules to go modules #732

merged 10 commits into from Aug 13, 2020

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Aug 12, 2020 •
edited

@codecov
Copy link

codecov bot commented Aug 12, 2020 •
edited

Codecov Report

Merging #732 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   49.97%   49.93%   -0.04%     
==========================================
  Files         421      421              
  Lines       53541    53541              
==========================================
- Hits        26755    26734      -21     
- Misses      24713    24733      +20     
- Partials     2073     2074       +1
Impacted Files Coverage Δ
inference/synapse/local_infer.go 0.00% <ø> (ø)
inference/synapse/synapse.go 0.00% <ø> (ø)
consensus/cuckoo/sealer.go 0.00% <0.00%> (-6.76%) ⬇️
consensus/cuckoo/cuckoo.go 31.91% <0.00%> (-4.26%) ⬇️
p2p/rlpx.go 69.40% <0.00%> (-2.55%) ⬇️
p2p/nat/natupnp.go 41.28% <0.00%> (-1.84%) ⬇️
trie/proof.go 75.74% <0.00%> (-1.50%) ⬇️
trie/trie.go 83.40% <0.00%> (-0.86%) ⬇️
p2p/peer.go 78.99% <0.00%> (ø)
p2p/server.go 66.98% <0.00%> (ø)
... and 5 more

@ucwong ucwong mentioned this pull request Aug 12, 2020
Merged
@ucwong ucwong requested a review from DhunterAO August 12, 2020 06:52
@ucwong ucwong marked this pull request as draft August 12, 2020 06:52
@ucwong ucwong linked an issue Aug 12, 2020 that may be closed by this pull request
Single binary file and cgo used #584
Closed
@ucwong ucwong marked this pull request as ready for review August 12, 2020 07:37
@ucwong ucwong added the enhancement New feature or request label Aug 12, 2020
DhunterAO
DhunterAO approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@DhunterAO DhunterAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ucwong ucwong merged commit c52c1f1 into master Aug 13, 2020
@wlt-cortex wlt-cortex deleted the cvm-runtime branch January 7, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhunterAO DhunterAO DhunterAO approved these changes

@declmal declmal declmal approved these changes

@wlt-cortex wlt-cortex Awaiting requested review from wlt-cortex

@ShadowErii ShadowErii Awaiting requested review from ShadowErii

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single binary file and cgo used
3 participants
@ucwong @DhunterAO @declmal